Add the ability to specify the secrete key #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While adding python3 support (743b6ce) signature functionality was broken. The reason - before the patch, we worked with the subprocess as if the streams (STDIN, STDOUT) were opened in text mode, but by default they are opened as binary streams.
LeonidVas
force-pushed
the
lvasiliev/gh-19-use-custom-gpg-key
branch
from
11fd256 to
526a396
Compare
|
The PR adds only the ability to specify which secrete key must be used for signature , because such solution, on the one hand, allows us to set a specific key for signing (which is not necessarily the default) and, on the other hand, allows to reduce the amount of logic added to the tool. |
Totktonada
reviewed
May 19, 2021
Totktonada
reviewed
May 19, 2021
Totktonada
reviewed
May 19, 2021
Totktonada
reviewed
May 19, 2021
Before the patch to specify the secrete key option "--default-key" was used. But it's not so clear for 2 reasons: - If the specified key is absent, the current default key will be used. - We don't want to change the default secrete key, we want to sign some data by specified key. Now we are using the "-u" option. As a result: if the specified key is absent, an error will be returned and the key used by default is not change now. Part of #19
LeonidVas
force-pushed
the
lvasiliev/gh-19-use-custom-gpg-key
branch
from
526a396 to
d17c275
Compare
|
All my comments are just thoughts around the code, they are not about real problems. I'll add Konstantin as the final reviewer. |
Totktonada
approved these changes
May 21, 2021
LeonidVas
force-pushed
the
lvasiliev/gh-19-use-custom-gpg-key
branch
5 times, most recently
from
776cc6e to
56a6158
Compare
|
@knazarov can you review the PR? |
Totktonada
reviewed
May 28, 2021
Totktonada
reviewed
May 28, 2021
LeonidVas
force-pushed
the
lvasiliev/gh-19-use-custom-gpg-key
branch
3 times, most recently
from
704e555 to
4c59dbd
Compare
Added the ability to specify the gpg secret key for signing by using the env variable. Closes #19
LeonidVas
force-pushed
the
lvasiliev/gh-19-use-custom-gpg-key
branch
from
4c59dbd to
5057928
Compare
LeonidVas
force-pushed
the
lvasiliev/gh-19-use-custom-gpg-key
branch
from
5057928 to
e24defa
Compare
knazarov
approved these changes
Jun 1, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes several fixes for signature and adds the ability to specify the gpg secret key for signing by using the env variable.