api: fix panic in conn.NewWatcher() #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImeevMA
force-pushed
the
imeevma/gh-438-fix-panic-new-watcher-during-reconnect
branch
from
3ea3046 to
a6a4988
Compare
bigbes
force-pushed
the
imeevma/gh-438-fix-panic-new-watcher-during-reconnect
branch
from
20a9615 to
f4aa3d5
Compare
oleg-jukovec
requested changes
Jun 26, 2025
bigbes
force-pushed
the
imeevma/gh-438-fix-panic-new-watcher-during-reconnect
branch
2 times, most recently
from
72da2b9 to
86a3a66
Compare
bigbes
force-pushed
the
imeevma/gh-438-fix-panic-new-watcher-during-reconnect
branch
2 times, most recently
from
c0bc42a to
8e181d6
Compare
Before this patch, `conn.c` was not checked for `nil` before calling its method. This could cause a panic if the connection was lost or closed. Closes #438
bigbes
force-pushed
the
imeevma/gh-438-fix-panic-new-watcher-during-reconnect
branch
from
8e181d6 to
85aeec8
Compare
oleg-jukovec
approved these changes
Jun 27, 2025
oleg-jukovec
requested review from
patapenka-alexey
and removed request for
dmyger
patapenka-alexey
approved these changes
Jun 27, 2025
oleg-jukovec
deleted the
imeevma/gh-438-fix-panic-new-watcher-during-reconnect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch,
conn.cwas not checked fornilbefore calling its method. This could cause a panic if the connection was lost or closed.Closes #438
What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues: #438