api: add ConnectionHandler to the connection_pool #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
from
391d4e7 to
2a91428
Compare
|
I put it back in draft to make it easier to review and merge. It will be ready for review after #208 |
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
3 times, most recently
from
f9bad2a to
77415e3
Compare
To be honest, it makes the whole situation a bit more complicated. When I see the draft, I suppose it's not ready for review. |
3 tasks
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
from
77415e3 to
da2b0e5
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
from
da2b0e5 to
8b54c9e
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
2 times, most recently
from
be96977 to
ebc71a6
Compare
oleg-jukovec
changed the title
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
from
ebc71a6 to
10e95f1
Compare
DifferentialOrange
approved these changes
Sep 2, 2022
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
from
10e95f1 to
fac406e
Compare
ConnectionHandler provides callbacks for components interested in handling changes of connections in a ConnectionPool. We have to take into account that user callbacks can take an indefinite amount of time. The simplest solution is to process each connection in a separate goroutine. This should not affect to performance because most of the time these goroutines are blocked. Closes #178
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
from
fac406e to
6dccdd5
Compare
DifferentialOrange
approved these changes
Sep 5, 2022
AnaNek
approved these changes
Sep 6, 2022
oleg-jukovec
deleted the
oleg-jukovec/gh-178-connection-pool-callbacks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionHandler provides callbacks for components interested in handling changes of connections in a ConnectionPool.
We have to take into account that user callbacks can take an indefinite amount of time. The simplest solution is to process each connection in a separate goroutine. This should not affect to performance because most of the time these goroutines are blocked.
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #178
The pull request is based on #208. You need to review only a last commit until #208 is not merged.