api: meaningful read/write networt error

We need to add meaningful error descriptions for a read/write socket
errors.

Part of #129

Author: oleg-jukovec

CHANGELOG.md

@@ -14,6 +14,7 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
 - Enumeration types for RLimitAction/iterators (#158)
 - IsNullable flag for Field (#302)
 - More linters on CI (#310)
+- Meaningful description for read/write socket errors (#129)
 
 ### Changed
 

connection.go

@@ -789,6 +789,10 @@ func (conn *Connection) writer(w writeFlusher, c Conn) {
 			runtime.Gosched()
 			if len(conn.dirtyShard) == 0 {
 				if err := w.Flush(); err != nil {
+					err = ClientError{
+						ErrIoError,
+						fmt.Sprintf("failed to flush data to the connection: %s", err),
+					}
 					conn.reconnect(err, c)
 					return
 				}
@@ -812,6 +816,10 @@ func (conn *Connection) writer(w writeFlusher, c Conn) {
 			continue
 		}
 		if _, err := w.Write(packet.b); err != nil {
+			err = ClientError{
+				ErrIoError,
+				fmt.Sprintf("failed to write data to the connection: %s", err),
+			}
 			conn.reconnect(err, c)
 			return
 		}
@@ -868,12 +876,20 @@ func (conn *Connection) reader(r io.Reader, c Conn) {
 	for atomic.LoadUint32(&conn.state) != connClosed {
 		respBytes, err := read(r, conn.lenbuf[:])
 		if err != nil {
+			err = ClientError{
+				ErrIoError,
+				fmt.Sprintf("failed to read data from the connection: %s", err),
+			}
 			conn.reconnect(err, c)
 			return
 		}
 		resp := &Response{buf: smallBuf{b: respBytes}}
 		err = resp.decodeHeader(conn.dec)
 		if err != nil {
+			err = ClientError{
+				ErrProtocolError,
+				fmt.Sprintf("failed to decode IPROTO header: %s", err),
+			}
 			conn.reconnect(err, c)
 			return
 		}
@@ -883,6 +899,10 @@ func (conn *Connection) reader(r io.Reader, c Conn) {
 			if event, err := readWatchEvent(&resp.buf); err == nil {
 				events <- event
 			} else {
+				err = ClientError{
+					ErrProtocolError,
+					fmt.Sprintf("failed to decode IPROTO_EVENT: %s", err),
+				}
 				conn.opts.Logger.Report(LogWatchEventReadFailed, conn, err)
 			}
 			continue

errors.go

@@ -45,7 +45,7 @@ func (clierr ClientError) Error() string {
 // - request is aborted due to rate limit
 func (clierr ClientError) Temporary() bool {
 	switch clierr.Code {
-	case ErrConnectionNotReady, ErrTimeouted, ErrRateLimited:
+	case ErrConnectionNotReady, ErrTimeouted, ErrRateLimited, ErrIoError:
 		return true
 	default:
 		return false
@@ -60,4 +60,5 @@ const (
 	ErrTimeouted          = 0x4000 + iota
 	ErrRateLimited        = 0x4000 + iota
 	ErrConnectionShutdown = 0x4000 + iota
+	ErrIoError            = 0x4000 + iota
 )