pool: fix flaky TestConnectionHandlerOpenUpdateClose

oleg-jukovec · oleg-jukovec · commit 1cb4e0beda6a · 2022-10-31T14:08:37.000+03:00
It's better to wait for a discovered event instead of deactivated
to handle finish of a role update.
diff --git a/connection_pool/connection_pool_test.go b/connection_pool/connection_pool_test.go
@@ -337,7 +337,7 @@ func TestConnectionHandlerOpenUpdateClose(t *testing.T) {
 	for i := 0; i < 100; i++ {
 		// Wait for read_only update, it should report about close connection
 		// with old role.
-		if h.deactivated >= 1 {
+		if h.discovered >= 3 {
 			break
 		}
 		time.Sleep(poolOpts.CheckTimeout)

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ func TestConnectionHandlerOpenUpdateClose(t *testing.T) {`
`337`	`337`	`for i := 0; i < 100; i++ {`
`338`	`338`	`// Wait for read_only update, it should report about close connection`
`339`	`339`	`// with old role.`
`340`		`- if h.deactivated >= 1 {`
	`340`	`+ if h.discovered >= 3 {`
`341`	`341`	`break`
`342`	`342`	`}`
`343`	`343`	`time.Sleep(poolOpts.CheckTimeout)`