Skip to content

Adds isolated instance mode description #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: latest
Choose a base branch
from

Conversation

AArdeev
Copy link
Contributor

@AArdeev AArdeev commented May 27, 2025

The ```isolated:true``` option moves the instance to RO mode
In this mode, various debugging & maintanance operations can be performed

Fixes #4632
@AArdeev AArdeev requested a review from Totktonada May 27, 2025 14:03
@AArdeev AArdeev self-assigned this May 27, 2025
@AArdeev AArdeev added documentation Improvements or additions to documentation config 3.3 labels May 27, 2025
@github-actions github-actions bot temporarily deployed to branch-gh-4632-add-isolated-mode-on-instance May 27, 2025 14:04 Destroyed
Fixes language and syntax
@github-actions github-actions bot temporarily deployed to branch-gh-4632-add-isolated-mode-on-instance May 28, 2025 05:41 Destroyed
@github-actions github-actions bot temporarily deployed to branch-gh-4632-add-isolated-mode-on-instance May 28, 2025 05:53 Destroyed
@AArdeev AArdeev added the server [area] Task relates to Tarantool's server (core) functionality label May 28, 2025
Comment on lines 2851 to 2856
The isolated mode moves the instance to the read-only state, in which:

* iproto stops listening for new connections
* iproto drops all the current connections
* The instance is disconnected from all the replication upstreams
* Other replicaset members exclude the isolated instance from the replication upstreams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording seems a bit misleading: 'read-only state, which stops iproto and disconnects replication'. In fact, the isolated state/mode sets the read-only state, stops iproto and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

* The instance is disconnected from all the replication upstreams
* Other replicaset members exclude the isolated instance from the replication upstreams

Once the mode is enabled, any request trying to change persistent data will fail with the ``ER_READONLY`` error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A remote request likely just fails, because we drop iproto connections. Not sure that we should add a note regarding ER_READONLY.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

i-002: {}
i-003: {}
i-004:
isolated: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: GitHub shows a red circle, when there is no newline symbol at the end of the file.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 257 to 259
.. NOTE::

To avoid brain split between two masters, one of the instances may be put in the :ref:`isolated mode <_configuration_reference_isolated_mode>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gives a false impression that the isolated mode somehow helps to avoid split-brain, but it means that we should detect is somehow faster than tarantool itself. It seems strange.

Here we can fight with consequences of split-brain to some extent. At least, isolate the broken instance from client requests using the config option.

Let's discuss how to better express it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3 config documentation Improvements or additions to documentation server [area] Task relates to Tarantool's server (core) functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: isolated mode for an instance
2 participants