Skip to content

Update the 'Creating your first Tarantool database' guide #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 25, 2023

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Dec 13, 2023

@xuniq xuniq force-pushed the gh-3704-create-db-guide branch from a93ade8 to 9d642c1 Compare December 14, 2023 08:29
@xuniq xuniq marked this pull request as ready for review December 14, 2023 08:37
@xuniq xuniq linked an issue Dec 14, 2023 that may be closed by this pull request
@xuniq xuniq force-pushed the gh-3704-create-db-guide branch from 5647fb0 to 539a482 Compare December 20, 2023 09:26
@xuniq xuniq requested a review from Totktonada December 20, 2023 09:26
@xuniq xuniq force-pushed the gh-3704-create-db-guide branch from 539a482 to a1214dd Compare December 20, 2023 10:14
Comment on lines 232 to 228
The ``listen`` value can be any form of a :ref:`URI <index-uri>` (uniform resource identifier).
You can send requests to the listen URI using:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not so now, see #3945.

You can send requests to the listen URI using:

* ``telnet``
* a :ref:`connector <index-box_connectors>`
* another instance of Tarantool (using the :ref:`console <console-module>` module)
* :ref:`tt <tt-cli>` administrative utility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is for a control (console) socket. iproto.listen is about a binary protocol socket. You can't work with it using telnet.

OTOH, you can't use a connector to connect to a console (not a binary protocol socket).

Maybe we should describe it in a more general context, not just iproto.listen?

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK in general.

Highlighted several chunks that doubt me a bit.

@xuniq xuniq force-pushed the gh-3704-create-db-guide branch from 02c8888 to 048f4b8 Compare December 22, 2023 07:12
@p7nov p7nov self-requested a review December 25, 2023 11:42
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuniq I took the liberty to somehow finalize this PR to be able to publish it with 3.0 docs – we don't have another starting point right now, so it's critical.
You can return to this task later if you find it unfinished.

@p7nov p7nov merged commit 2c0d535 into 3.0 Dec 25, 2023
@p7nov p7nov deleted the gh-3704-create-db-guide branch December 25, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the 'Creating your first Tarantool database' guide
3 participants