Skip to content

Update Vale rules #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Update Vale rules #3753

merged 1 commit into from
Oct 5, 2023

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented Oct 4, 2023

  • Added a suggestion for swapping flag with option in a case of CLI options.
  • Made some rules a bit weaker.
  • Added missing terms.

Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update!
Added a couple more suggestions.

subcommand
vshard
boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
boolean
boolean
failover

autoincrement
etcd
xlog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should encourage using "xlog" as a word in plain text. The correct entity name is "write-ahead log".

@@ -251,3 +251,5 @@ exceptions:
- YAML
- ZAP
- ZIP
- PAP
- CHAP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- CHAP
- CHAP
- APT

@andreyaksenov andreyaksenov merged commit 94f0190 into latest Oct 5, 2023
@andreyaksenov andreyaksenov deleted the update-vale-rules branch October 5, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants