-
Notifications
You must be signed in to change notification settings - Fork 43
Document the 'wal_queue_max_size' option #3338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the patch!
LGTM.
I leave it for you to decide whether any explanations about raising or lowering wal_queue_max_size
are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just one minor fix (see the suggestion).
doc/concepts/engines/memtx.rst
Outdated
@@ -55,7 +55,7 @@ For more details, see the ``box.slab`` module :doc:`reference </reference/refere | |||
.. image:: memtx/spaces_indexes.svg | |||
|
|||
Also inside the TX thread, there is an event loop. Within the event loop, there are a number of :ref:`fibers <fiber-fibers>`. | |||
Fibers are cooperative primitives that allows interaction with spaces, that is, reading and writting the data. | |||
Fibers are cooperative primitives that allows interaction with spaces, that is, reading and writing the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fibers are cooperative primitives that allows interaction with spaces, that is, reading and writing the data. | |
Fibers are cooperative primitives that allow interaction with spaces, that is, reading and writing the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Document the 'wal_queue_max_size' option and fix some typos along the way. Resolves #1969
Add the
wal_queue_max_size
option to the reference (#1969).Resolves #1969