Skip to content

Document the 'wal_queue_max_size' option #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2023
Merged

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented Feb 16, 2023

Add the wal_queue_max_size option to the reference (#1969).

Resolves #1969

Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the patch!

LGTM.
I leave it for you to decide whether any explanations about raising or lowering wal_queue_max_size are needed.

@andreyaksenov andreyaksenov requested a review from p7nov February 17, 2023 09:26
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one minor fix (see the suggestion).

@@ -55,7 +55,7 @@ For more details, see the ``box.slab`` module :doc:`reference </reference/refere
.. image:: memtx/spaces_indexes.svg

Also inside the TX thread, there is an event loop. Within the event loop, there are a number of :ref:`fibers <fiber-fibers>`.
Fibers are cooperative primitives that allows interaction with spaces, that is, reading and writting the data.
Fibers are cooperative primitives that allows interaction with spaces, that is, reading and writing the data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fibers are cooperative primitives that allows interaction with spaces, that is, reading and writing the data.
Fibers are cooperative primitives that allow interaction with spaces, that is, reading and writing the data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@andreyaksenov andreyaksenov merged commit 25a5412 into latest Feb 17, 2023
@andreyaksenov andreyaksenov deleted the wal_queue_max_size branch February 17, 2023 10:23
p7nov pushed a commit that referenced this pull request Mar 24, 2023
Document the 'wal_queue_max_size' option and fix some typos along the way.

Resolves #1969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] new configuration option: 'wal_queue_max_size'
3 participants