-
Notifications
You must be signed in to change notification settings - Fork 43
Document graceful shutdown of net.box connections #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb95c08
to
a1bfcad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I briefly looked through the text, and here are some suggestions.
doc/reference/reference_lua/box_ctl/set_on_shutdown_timeout.rst
Outdated
Show resolved
Hide resolved
fffef1f
to
bd7c227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a user-friendly description! Just a couple of minor corrections, and we can merge this.
bd7c227
to
8149b12
Compare
8149b12
to
c8356ae
Compare
Fixes #2633
Deploy:
https://docs.d.tarantool.io/en/doc/gh-2633-netbox-shutdown/reference/reference_lua/box_events/system_events/#box-shutdown
https://docs.d.tarantool.io/en/doc/gh-2633-netbox-shutdown/dev_guide/internals/box_protocol/#graceful-shutdown-protocol
https://docs.d.tarantool.io/en/doc/gh-2633-netbox-shutdown/reference/reference_lua/net_box/
https://docs.d.tarantool.io/en/doc/gh-2633-netbox-shutdown/reference/reference_lua/net_box/#net-box-on-shutdown