Skip to content

Document graceful shutdown of net.box connections #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 7, 2022

Conversation

@xuniq xuniq marked this pull request as draft August 17, 2022 05:49
@xuniq xuniq force-pushed the gh-2633-netbox-shutdown branch from fb95c08 to a1bfcad Compare August 23, 2022 21:54
@xuniq xuniq marked this pull request as ready for review August 23, 2022 21:57
@xuniq xuniq requested a review from locker August 24, 2022 06:36
@locker locker requested a review from patiencedaur August 24, 2022 08:54
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I briefly looked through the text, and here are some suggestions.

@xuniq xuniq force-pushed the gh-2633-netbox-shutdown branch from fffef1f to bd7c227 Compare September 1, 2022 10:08
@xuniq xuniq requested a review from patiencedaur September 1, 2022 11:17
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a user-friendly description! Just a couple of minor corrections, and we can merge this.

@xuniq xuniq requested a review from patiencedaur September 5, 2022 10:45
@xuniq xuniq force-pushed the gh-2633-netbox-shutdown branch from bd7c227 to 8149b12 Compare September 5, 2022 10:47
@xuniq xuniq force-pushed the gh-2633-netbox-shutdown branch from 8149b12 to c8356ae Compare September 7, 2022 09:51
@xuniq xuniq removed the request for review from patiencedaur September 7, 2022 09:52
@xuniq xuniq merged commit 1409c55 into latest Sep 7, 2022
@xuniq xuniq deleted the gh-2633-netbox-shutdown branch September 7, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document graceful shutdown of net.box connections
3 participants