Add description of vshard.enable/disable() #3025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add description of the automatic and manual router API's enabling/disabling Resolves #3012
github-actions
bot
temporarily deployed
to
branch-gh-3012-vshard-router-enable-disable
Serpentian
commented
Jul 12, 2022
| .. note:: | ||
|
|
||
| ``vshard.router.enable()`` cannot be used for enabling a router | ||
| API that was automatically disabled due to a running configuration |
There was a problem hiding this comment.
Actually, vshard.router.cfg is a configuration process only for the static router. But vshard supports multiple routers in a single instance. These ones can be created via vhard.router.new. During configuration every router is blocked on its own, and blocking API of the one uncofigured instance doesn't affect others.
If we want to specify functions, used for configuration, explicitly, we should mention both of them. Another solution can be just stay on 'running configuration process'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabling/disabling
Resolves #3012