fio: clarify fio.basename() with slash at end #3013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
branch-gh-2124-fio-basename-trailing-slash
|
(I'm not sure that the wording is nice, but it is my best tonight. I would like to have this caution in the documentation and open for proposals.) |
patiencedaur
reviewed
Jul 9, 2022
doc/reference/reference_lua/fio.rst
Outdated
| @@ -197,6 +197,10 @@ Below is a list of all ``fio`` functions and members. | |||
| Given a full path name, remove all but the final part (the file name). | |||
| Also remove the suffix, if it is passed. | |||
|
|
|||
| Note that the basename of a path with the trailing slash is the empty | |||
There was a problem hiding this comment.
Suggested change
| Note that the basename of a path with the trailing slash is the empty | |
| Note that the basename of a path with a trailing slash is an empty |
There was a problem hiding this comment.
I guess I should also replace
Example with the trailing slash:
with
Example with a trailing slash:
Totktonada
force-pushed
the
Totktonada/gh-2124-fio-basename-trailing-slash
branch
from
d9133c7 to
01493f5
Compare
github-actions
bot
temporarily deployed
to
branch-gh-2124-fio-basename-trailing-slash
patiencedaur
deleted the
Totktonada/gh-2124-fio-basename-trailing-slash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2124