Skip to content

Updating support for interactive transactions in net.box #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 27, 2022
Merged

Updating support for interactive transactions in net.box #2878

merged 9 commits into from
May 27, 2022

Conversation

rindblack15
Copy link
Contributor

Update section Index
Add information about the begin, commit and rollback methods

@rindblack15
Update net_box.rst
f31bc29 
Update section Index
Add information about the begin, commit and rollback methods
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 18, 2022 07:41 Inactive
@rindblack15 rindblack15 linked an issue May 18, 2022 that may be closed by this pull request
add interactive transaction support in net.box #2311
Closed
@rindblack15
Update net_box.rst
5c44872 
Update 'Index' section
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 19, 2022 06:47 Inactive
@rindblack15
Update net_box.rst
906d487 
Update 'Index' section
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 19, 2022 07:57 Inactive
@rindblack15
Update net_box.rst
0e6853f 
Update Index
Restrict the list of methods
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 20, 2022 13:12 Inactive
@rindblack15
Update net_box.rst
c9f564d 
Improve grammar
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 20, 2022 13:22 Inactive
@rindblack15 rindblack15 requested a review from xuniq May 23, 2022 06:05
xuniq
xuniq approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@xuniq xuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

patiencedaur
patiencedaur suggested changes May 24, 2022
View reviewed changes
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the examples more elaborate. Right now they repeat method declaration and look redundant.

@rindblack15
Update net_box.rst
87a6add 
Update examples for the methods
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 25, 2022 06:39 Inactive
@rindblack15 rindblack15 marked this pull request as ready for review May 25, 2022 06:48
@rindblack15 rindblack15 requested a review from patiencedaur May 25, 2022 06:49
patiencedaur
patiencedaur reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

@rindblack15
Update net_box.rst
43e8767 
Clarify that transactions are "stream"
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 25, 2022 07:12 Inactive
@rindblack15
Update net_box.rst
775cccd 
Fix syntax
Add comments
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 26, 2022 05:00 Inactive
@rindblack15 rindblack15 requested a review from patiencedaur May 26, 2022 07:50
@rindblack15
Update net_box.rst
b6236c0 
Update examples
@github-actions github-actions bot temporarily deployed to branch-gh-2311-interactive_transaction_support_in_net.box May 26, 2022 13:16 Inactive
@rindblack15 rindblack15 merged commit 262d10d into latest May 27, 2022
@rindblack15 rindblack15 deleted the rindblack15/gh-2311-interactive_transaction_support_in_net.box branch May 27, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patiencedaur patiencedaur patiencedaur approved these changes

@xuniq xuniq xuniq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add interactive transaction support in net.box
3 participants
@rindblack15 @patiencedaur @xuniq