Skip to content

Add environment variable names for documented configuration options #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2022

Conversation

patiencedaur
Copy link
Contributor

@patiencedaur patiencedaur commented May 17, 2022

Resolves #2722
Resolves #1012
(The latter doesn't deserve a separate PR)

@patiencedaur patiencedaur requested a review from Totktonada May 17, 2022 08:11
@github-actions github-actions bot temporarily deployed to branch-gh-2722-env-var May 17, 2022 08:14 Inactive
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems visually.

@github-actions github-actions bot temporarily deployed to branch-gh-2722-env-var May 17, 2022 08:22 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2722-env-var May 17, 2022 08:25 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2722-env-var May 17, 2022 08:36 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2722-env-var May 17, 2022 08:49 Inactive
@patiencedaur patiencedaur merged commit 7842958 into latest May 17, 2022
@patiencedaur patiencedaur deleted the gh-2722-env-var branch May 17, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] Add env variable name in description of all configuration parameters feedback: Submodule box.cfg
2 participants