Skip to content

Xuniq/gh 1751 fix typos in connecting from your favorite language #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Feb 28, 2021

removed confusing punctuation marks in python, php and go getting_started

fixes gh-1751

@@ -196,7 +196,7 @@ to ``update``, but creates a new tuple if the old one was not found.

$tester->upsert([4, 'Another band', 2000], Operations::add(2, 5));

This increases by 5 the value of field ``2`` in the tuple with ``id`` = 4, -- or
This increases by 5 the value of field ``2`` in the tuple with ``id`` = 4 or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the whole expression as code. Add comma before "or".

Suggested change
This increases by 5 the value of field ``2`` in the tuple with ``id`` = 4 or
This increases by 5 the value of field ``2`` in the tuple with ``id = 4``, or

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix formatting for

offset = 0 and limit = 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "where id equals 4".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion became an issue: #1886

@NickVolynkin NickVolynkin merged commit 8f86dcd into latest Mar 1, 2021
@NickVolynkin NickVolynkin deleted the xuniq/gh-1751 branch March 1, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] feedback: Connecting from your favorite language | Tarantool
2 participants