Skip to content

gh-1825 Add tntcxx submodule and publish C++ connector Getting started #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

veod32
Copy link
Collaborator

@veod32 veod32 commented Feb 20, 2021

Part of #1825

@veod32 veod32 requested a review from NickVolynkin February 20, 2021 14:11
@veod32 veod32 force-pushed the veod32/gh-1709-cxx-connector branch from ce2ef7d to 9055fa7 Compare February 20, 2021 14:24
# tntcxx submodule

/doc/getting_started/getting_started_cxx.rst
/doc/getting_started/_includes/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас же уже есть файлы в этой директории? Если и нет, то может появиться. Если что-то приходит из tntcxx, пусть оно ложится в директорию cxx или cxx/_includes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай пока так оставим на эту итерацию. Если сейчас поменять структуру, нужно в нескольких местах исправлять пути, в т.ч. в сорсах документа.

@@ -30,6 +30,10 @@ luatest_dest="${project_root}/doc/reference/reference_rock/luatest"
cartridge_kubernetes_root="${project_root}/modules/tarantool-operator/doc/cartridge_kubernetes_guide"
cartridge_kubernetes_dest="${rst_dest}/"

tntcxx_root="${project_root}/modules/tntcxx"
tntcxx_gs_dest="${project_root}/doc/getting_started/"
tntcxx_api_dest="${project_root}/doc/book/connectors/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А это пока что не копируем, да?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пока не копируем контент по API сюда, т.к. он еще в драфтовом виде.
tntcxx_api_dest="${project_root}/doc/book/connectors/"

@@ -46,6 +50,9 @@ yes | cp -rf "${cartridge_cli_root}/README.rst" "${cartridge_cli_index_dest}"
mkdir -p "${cartridge_kubernetes_dest}"
yes | cp -rf "${cartridge_kubernetes_root}" "${cartridge_kubernetes_dest}"

yes | cp -rf "${tntcxx_root}/doc/tntcxx_getting_started.rst" "${tntcxx_gs_dest}/getting_started_cxx.rst"
yes | cp -rf "${tntcxx_root}/examples/" "${tntcxx_gs_dest}/_includes/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут можно сначала создать директорию getting_started/cxx/, а потом в нее копировать examples как _includes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай пока так оставим на эту итерацию. Если сейчас поменять структуру, нужно в нескольких местах это исправлять, в т.ч. в сорсах документа.

- Update .gitignore: mention rst files copied from tarantool/tntcxx

Part of #1709
- update .gitignore and update_submodules.sh
- update index pages /book/connectors/index.rst and /getting_started/getting_started_connectors.rst to publish C++ connector Getting Started

Part of #1825
@NickVolynkin NickVolynkin force-pushed the veod32/gh-1709-cxx-connector branch from 9055fa7 to c17ed10 Compare February 24, 2021 12:57
@NickVolynkin NickVolynkin merged commit 36b38f9 into latest Feb 24, 2021
@NickVolynkin NickVolynkin deleted the veod32/gh-1709-cxx-connector branch February 24, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants