Skip to content

Fix URLs in iproto PlantUML tables #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
p7nov opened this issue Dec 5, 2022 · 0 comments · Fixed by #3256
Closed
1 task

Fix URLs in iproto PlantUML tables #3254

p7nov opened this issue Dec 5, 2022 · 0 comments · Fixed by #3256
Assignees
Labels
bug Something isn't working iproto Related to the iproto protocol reference [location] Tarantool manual, Reference part

Comments

@p7nov
Copy link
Contributor

p7nov commented Dec 5, 2022

Info

Root document: https://www.tarantool.io/en/doc/latest/dev_guide/internals/box_protocol/ - all pages inside that have PlantUML diagrams.

What's wrong?

Some links from PlantUML diagrams are broken.
They have a part of URL attached two times.

Example: IPROTO_SELECT
first link in the request structure table points to https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/requests/**tarantool.io/en/doc/latest/dev_guide/internals/iproto/keys**

Root cause

Such URL come from incorrect .puml files. Links inside them should start from [[https://tarantool.io/en/doc/latest/dev_guide/internals/iproto/keys IPROTO_REQUEST_TYPE]]": "IPROTO_SELECT",

Broken links are missing https:// in the beginning.

Planning checklist

  • Check and update all .puml files to correct links.
@p7nov p7nov added bug Something isn't working reference [location] Tarantool manual, Reference part iproto Related to the iproto protocol labels Dec 5, 2022
@p7nov p7nov self-assigned this Dec 8, 2022
p7nov added a commit that referenced this issue Dec 9, 2022
p7nov added a commit that referenced this issue Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iproto Related to the iproto protocol reference [location] Tarantool manual, Reference part
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant