Skip to content

api: forbid using space id in len #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DifferentialOrange
Copy link
Member

Using space id instead of a space name in sharded systems may be dangerous until one sets all space id manually. This is a breaking change. The feature was deprecated since 0.14.0.

I didn't forget about

  • Tests
  • Changelog
  • Documentation (it seems like there are no traces left already)

Closes #255

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-255-forbid-len-by-id branch 2 times, most recently from 048fe34 to f935c70 Compare January 27, 2023 16:04
Using space id instead of a space name in sharded systems may be
dangerous until one sets all space id manually. This is a breaking
change. The feature was deprecated since 0.14.0.

Closes #255
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-255-forbid-len-by-id branch from f935c70 to aa3c2fd Compare January 27, 2023 16:09
@DifferentialOrange DifferentialOrange merged commit 506f697 into master Jan 30, 2023
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-255-forbid-len-by-id branch January 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow using space_id
2 participants