Skip to content

Configure with clusterwide config #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DifferentialOrange opened this issue Nov 23, 2022 · 0 comments · Fixed by #339
Closed

Configure with clusterwide config #332

DifferentialOrange opened this issue Nov 23, 2022 · 0 comments · Fixed by #339
Assignees
Labels
feature A new functionality

Comments

@DifferentialOrange
Copy link
Member

For now there is no way to change configuration (for example, enable metrics) with clusterwide config. User need to write a specific role with crud.cfg to enable metrics. It in inconvenient for cases when one implements the application outside the Tarantool cluster (for example, with Java and cartridge-java connector).

@DifferentialOrange DifferentialOrange added feature A new functionality teamE labels Nov 23, 2022
@DifferentialOrange DifferentialOrange self-assigned this Jan 27, 2023
DifferentialOrange added a commit that referenced this issue Jan 27, 2023
The comment about routes is likely has been introduced because
cartridge.roles.crud-router role was based on cartridge.roles.metrics
role, see [1].

1. https://github.com/tarantool/metrics/blob/5ac763d87b8ba140147a66a7ca60b35daf44b826/cartridge/roles/metrics.lua#L170

Part of #332
DifferentialOrange added a commit that referenced this issue Jan 27, 2023
After this patch, user may set crud.cfg with Cartridge clusterwide
configuration of `cartridge.roles.crud-router` role [1]. The behavior
is the same as in Lua crud.cfg call.

1. https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/

Closes #332
DifferentialOrange added a commit that referenced this issue Jan 27, 2023
The comment about routes is likely has been introduced because
cartridge.roles.crud-router role was based on cartridge.roles.metrics
role, see [1].

1. https://github.com/tarantool/metrics/blob/5ac763d87b8ba140147a66a7ca60b35daf44b826/cartridge/roles/metrics.lua#L170

Part of #332
DifferentialOrange added a commit that referenced this issue Jan 27, 2023
After this patch, user may set crud.cfg with Cartridge clusterwide
configuration of `cartridge.roles.crud-router` role [1]. The behavior
is the same as in Lua crud.cfg call.

1. https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/

Closes #332
DifferentialOrange added a commit that referenced this issue Jan 27, 2023
After this patch, user may set crud.cfg with Cartridge clusterwide
configuration of `cartridge.roles.crud-router` role [1]. The behavior
is the same as in Lua crud.cfg call.

1. https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/

Closes #332
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
The comment about routes is likely has been introduced because
cartridge.roles.crud-router role was based on cartridge.roles.metrics
role, see [1].

1. https://github.com/tarantool/metrics/blob/5ac763d87b8ba140147a66a7ca60b35daf44b826/cartridge/roles/metrics.lua#L170

Part of #332
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
After this patch, user may set crud.cfg with Cartridge clusterwide
configuration of `cartridge.roles.crud-router` role [1]. The behavior
is the same as in Lua crud.cfg call.

1. https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/

Closes #332
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
After this patch, user may set crud.cfg with Cartridge clusterwide
configuration of `cartridge.roles.crud-router` role [1]. The behavior
is the same as in Lua crud.cfg call.

1. https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/

Closes #332
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
The comment about routes is likely has been introduced because
cartridge.roles.crud-router role was based on cartridge.roles.metrics
role, see [1].

1. https://github.com/tarantool/metrics/blob/5ac763d87b8ba140147a66a7ca60b35daf44b826/cartridge/roles/metrics.lua#L170

Part of #332
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
After this patch, user may set crud.cfg with Cartridge clusterwide
configuration of `cartridge.roles.crud-router` role [1]. The behavior
is the same as in Lua crud.cfg call.

1. https://www.tarantool.io/en/doc/latest/book/cartridge/cartridge_dev/

Closes #332
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
Overview

  This release introduces a breaking change with removing a deprecated
  feature: `crud.len(space_id)`.

  This release also introduces a Cartridge clusterwide config to setup
  `crud.cfg`.

Breaking changes

  You cannot use space id as a space identifier in `crud.len` anymore.
  Use space name instead.

New features

  * Timeout condition for the validation of master presence in 
    replicaset and for the master connection (#95).
  * Cartridge clusterwide configuration for `crud.cfg` (#332).

Changes

  * Forbid using space id in `crud.len` (#255).

Fixes

  * Add validation of the master presence in replicaset and the 
    master connection to the `utils.get_space` method before 
    receiving the space from the connection (#331).
  * Fix fiber cancel on schema reload timeout in `call_reload_schema`
    (PR #337).
@DifferentialOrange DifferentialOrange mentioned this issue Feb 2, 2023
1 task
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
Overview

  This release introduces a breaking change with removing a deprecated
  feature: `crud.len(space_id)`.

  This release also introduces a Cartridge clusterwide config to setup
  `crud.cfg`.

Breaking changes

  You cannot use space id as a space identifier in `crud.len` anymore.
  Use space name instead.

New features

  * Timeout condition for the validation of master presence in 
    replicaset and for the master connection (#95).
  * Cartridge clusterwide configuration for `crud.cfg` (#332).

Changes

  * Forbid using space id in `crud.len` (#255).

Fixes

  * Add validation of the master presence in replicaset and the 
    master connection to the `utils.get_space` method before 
    receiving the space from the connection (#331).
  * Fix fiber cancel on schema reload timeout in `call_reload_schema`
    (PR #336).
DifferentialOrange added a commit that referenced this issue Feb 2, 2023
Overview

  This release introduces a breaking change with removing a deprecated
  feature: `crud.len(space_id)`.

  This release also introduces a Cartridge clusterwide config to setup
  `crud.cfg`.

Breaking changes

  You cannot use space id as a space identifier in `crud.len` anymore.
  Use space name instead.

New features

  * Timeout condition for the validation of master presence in 
    replicaset and for the master connection (#95).
  * Cartridge clusterwide configuration for `crud.cfg` (#332).

Changes

  * Forbid using space id in `crud.len` (#255).

Fixes

  * Add validation of the master presence in replicaset and the 
    master connection to the `utils.get_space` method before 
    receiving the space from the connection (#331).
  * Fix fiber cancel on schema reload timeout in `call_reload_schema`
    (PR #336).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant