Skip to content

Commit 1f685d2

Browse files
ArtDuakudiyar
andcommitted
Apply suggestions from code review
Co-authored-by: Alexey Kuzin <[email protected]>
1 parent b0d5358 commit 1f685d2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/main/java/io/tarantool/driver/api/tuple/TarantoolTuple.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
*/
1616
public interface TarantoolTuple extends Iterable<TarantoolField>, Packable {
1717
/**
18-
* Check whether tuple have information about space format
18+
* Check whether this tuple includes information about space format
1919
*
20-
* @return true if we obtain fields by names
20+
* @return true if we can obtain the tuple fields by names
2121
*/
22-
boolean metadataFormatIsEmpty();
22+
boolean hasMetadata();
2323

2424
/**
2525
* Get a tuple field by its position

src/main/java/io/tarantool/driver/core/tuple/TarantoolTupleImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public TarantoolTupleImpl(ArrayValue value, MessagePackMapper mapper, TarantoolS
137137
}
138138

139139
@Override
140-
public boolean metadataFormatIsEmpty() {
140+
public boolean hasMetadata() {
141141
return spaceMetadata == null || spaceMetadata.getSpaceFormatMetadata() == null ||
142142
spaceMetadata.getSpaceFormatMetadata().isEmpty();
143143
}

src/test/java/io/tarantool/driver/integration/ClusterTarantoolTupleClientIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import io.tarantool.driver.mappers.TarantoolTupleResultMapperFactory;
2323
import io.tarantool.driver.mappers.TarantoolTupleResultMapperFactoryImpl;
2424
import io.tarantool.driver.mappers.factories.DefaultMessagePackMapperFactory;
25-
import io.tarantool.driver.mappers.factories.ResultMapperFactoryFactoryImpl;
25+
2626
import org.junit.jupiter.api.BeforeAll;
2727
import org.junit.jupiter.api.Test;
2828
import org.slf4j.Logger;
@@ -405,7 +405,7 @@ public void callForTarantoolResultTest() throws Exception {
405405

406406
assertTrue(result.size() >= 3);
407407
TarantoolTuple tuple = result.get(0);
408-
assertFalse(tuple.metadataFormatIsEmpty());
408+
assertFalse(tuple.hasMetadata());
409409
assertEquals(1605, tuple.getInteger("year"));
410410

411411
result = client.call(
@@ -416,7 +416,7 @@ public void callForTarantoolResultTest() throws Exception {
416416
).get();
417417
assertTrue(result.size() >= 3);
418418
tuple = result.get(0);
419-
assertTrue(tuple.metadataFormatIsEmpty());
419+
assertTrue(tuple.hasMetadata());
420420
}
421421

422422
@Test

0 commit comments

Comments
 (0)