Android: tailscale app does not request storage permission #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ppaga opened this issue Mar 10, 2025 · 2 comments

Assignees

Labels

ppaga commented Mar 10, 2025

What is the issue?

On Android Pixel 7a: when trying to taildrop a file from linux, I get
500 Internal Server Error: open redacted.3e790f11: permission denied
and no notification on the phone.

When checking permissions, the tailscale app only has the notification permission and no other requested.

Steps to reproduce

No response

Are there any recent changes that introduced the issue?

No response

OS

No response

OS version

No response

Tailscale version

No response

Other software

No response

Bug report

No response

ppaga added bug needs-triage labels

nickoneill assigned kari-ts

nickoneill added OS-android and removed needs-triage labels

Contributor

kari-ts commented Mar 18, 2025

This is due to our use of getExternalStoragePublicDirectory, which is deprecated in Android 10+ because of changes to Android's management of scoped storage. The fix is to use Storage Access Framework instead.

Contributor

kari-ts commented Mar 19, 2025

SAF is designed to give users control over which directories and files an app can access, so it requires users select where Taildropped files are saved.
We currently set the directory during initialization when creating LocalBackend, but there are cases where Tailscale may be running without the app having been opened by the user (eg if Always On is enabled and the device has been restarted but the app hasn't been opened).
Since we will be adding an additional directory picker, this should get shown in MainActivity to users who haven't selected the Taildrop destination before when we are asking for other permissions.
Context.getExternalFilesDirs gives a directory on external storage that's private to the app and doesn't require permission - when a user has not selected the Taildrop location, Taildropped files should get saved there, and a notification shown explaining this and giving them the option to open up the directory picker, and once the location has been selected, files should be transferred to that location.

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

0a9a3d8

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts mentioned this issue

android: use SAF for storing Taildropped files tailscale/tailscale-android#632

Merged

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

e75eba9

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

7d814a6

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

8ecdb5b

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts mentioned this issue

ipnlocal, taildrop: use SAF for Android files #15545

Closed

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

3d78bbd

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

892300f

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

92047bf

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

63ba6eb

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

b583a00

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

b3e9390

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

a845a25

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

4a589ef

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

43452d2

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

e587f9b

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

e14f21d

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipnlocal, taildrop: use SAF for Android files

6663d5c

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

60862fc

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

15bd924

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

7d80b8d

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

36b8213

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

5fba29a

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

4cda1cb

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

25e3cd7

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

8e19414

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

aca0993

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

3e15c26

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

64c378d

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

199f027

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts pushed a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

e8ba16d

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts pushed a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

4554d8c

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

223cbc4

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts mentioned this issue

ipn,ipnlocal,taildrop: use SAF for Android files #15976

Merged

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

b9e039a

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

d797faf

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

2b01944

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

524f0ed

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files

9dcf44c

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit that referenced this issue


          ipn,ipnlocal,taildrop: use SAF for Android files (#15976)

5a8b99e

Create FileOps for calling platform-specific file operations such as SAF APIs in Taildrop
Update taildrop.PutFile to support both traditional and SAF modes

Updates #15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

b5b31c3

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files

0b959d4

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: use SAF for storing Taildropped files (#632)

bd51913

Use Android Storage Access Framework for receiving Taildropped files.

-Add a picker to allow users to select where Taildropped files go
-If no directory is selected, internal app storage is used
-Provide SAF API for Go to use when writing and renaming files
-Provide Android FileOps implementation

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: allow users to update taildrop directory

4b440d1

-Modify Permissions view to navigate to Taildrop dir view and Notifications view, and to reflect state
-Add Taildrop dir view which navigates to directory selector
-Add Notifications view which navigates to Taildrop notifications setting

Updates tailscale/tailscale#15263
Signed-off-by: kari-ts <[email protected]>

kari-ts mentioned this issue

android: allow users to update taildrop directory tailscale/tailscale-android#658

Merged

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: allow users to update taildrop directory

39a44e4

-Modify Permissions view to navigate to Taildrop dir view and Notifications view, and to reflect state
-Add Taildrop dir view which navigates to directory selector
-Add Notifications view which navigates to Taildrop notifications setting

Updates tailscale/tailscale#15263
Signed-off-by: kari-ts <[email protected]>

kari-ts added a commit to tailscale/tailscale-android that referenced this issue


          android: allow users to update taildrop directory (#658)

87f0e97

-Modify Permissions view to navigate to Taildrop dir view and Notifications view, and to reflect state
-Add Taildrop dir view which navigates to directory selector
-Add Notifications view which navigates to Taildrop notifications setting

Updates tailscale/tailscale#15263

Signed-off-by: kari-ts <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment