mdm: define TailscaleOnboardingSeen syspolicy on Android #648
Conversation
Adds an MDM setting `TailscaleOnboardingSeen` which allows for the intro screen to be skipped when set to true. Signed-off-by: zbuchheit <[email protected]>
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
![review-ai-agent[bot]](https://avatars.githubusercontent.com/in/1104228?s=60&v=4){kind=small}
| if (!introScreenViewed() && !mdmTailscaleOnboardingSeen()) { | ||
| navController.navigate("intro") | ||
| setIntroScreenViewed(true) |
There was a problem hiding this comment.
The condition if (!introScreenViewed() && !mdmTailscaleOnboardingSeen()) could lead to a logical issue. If both conditions are false, the intro screen will not be shown. However, if introScreenViewed() is false but mdmTailscaleOnboardingSeen() is true, you're still calling setIntroScreenViewed(true) in the block below. This means the local state will be marked as viewed even though the user didn't actually see the intro. Should you only mark it as viewed when actually showing it?
| @@ -97,6 +97,9 @@ object MDMSettings { | |||
| // Overrides the value provided by os.Hostname() in Go | |||
| val hostname = StringMDMSetting("Hostname", "Device Hostname") | |||
|
|
|||
| // Allows admins to skip the get started intro screen | |||
| val tailscaleOnboardingSeen = BooleanMDMSetting("TailscaleOnboardingSeen", "Suppress the intro screen") | |||
There was a problem hiding this comment.
Can you please use OnboardingFlow instead of TailscaleOnboardingSeen?
See also: tailscale/tailscale#13987 (comment)
There was a problem hiding this comment.
TLDR: We have TailscaleOnboardingSeen on macOS. It's not a great policy setting name, so we went with OnboardingFlow on Windows. We'll update the macOS client sometime, but let's stick with OnboardingFlow and show/hide as the values for any new platforms.
Adds an MDM setting
TailscaleOnboardingSeenwhich allows for the intro screen to be skipped when set to true.Updates https://github.com/tailscale/corp/issues/27966