Skip to content

Rust0.11 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2014
Merged

Rust0.11 #1

merged 2 commits into from
Jul 19, 2014

Conversation

kagiasoldaccount
Copy link
Contributor

These PR provides fixes allowing the library to compile and pass tests on rust 0.11 nightly (windows).

  1. because it is expected that cargo will now handle versioning of crates the crate_id attribute has been deprecated. In the future we need to consider adding cargo support.
  2. String indexing was removed from rust #12710 because string indexing was really byte indexing not character indexing. Also UTF-8 strings don't lend themselves to random access, you have to either iterate over them or build some an index mapping each graphene to an index.
    For now I assume this lib is only aiming for ASCII compatibility in which case byte indexing is okay. But we may want to think of Unicode support for eastern and middle-eastern users in the future.

all test pass on my machine

tailhook added a commit that referenced this pull request Jul 19, 2014
@tailhook tailhook merged commit c64be0b into tailhook:rust0.11 Jul 19, 2014
@tailhook
Copy link
Owner

Thanks! For the character indexing issue, it's just second character. It's easy to iterate for the second one (In fact in the ArgumentKind it's done so, so it seems just single place I'm missing). May be I'll find some time to build nightly and make real fix.

tailhook pushed a commit that referenced this pull request Mar 2, 2018
Specify version on Cargo.toml file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants