Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR provides fixes allowing the library to compile and pass tests on rust 0.11 nightly (windows).
crate_id
attribute has been deprecated. In the future we need to consider adding cargo support.For now I assume this lib is only aiming for ASCII compatibility in which case byte indexing is okay. But we may want to think of Unicode support for eastern and middle-eastern users in the future.
all test pass on my machine