Skip to content

Fix to fetch notion page block #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2021
Merged

Fix to fetch notion page block #12

merged 2 commits into from
Aug 8, 2021

Conversation

gnokoheat
Copy link
Collaborator

change notion-py package source to https://github.com/gnokoheat/notion-py

error

page = client.get_block(notion_page_url)

requests.exceptions.HTTPError: Invalid input.

reference

jamalex/notion-py#292

@gnokoheat gnokoheat requested a review from xissy as a code owner August 8, 2021 07:48
Copy link
Member

@xissy xissy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @gnokoheat LGTM. One nit is, why don't we add a commit sha on the notion-py requirement to make it explicit and avoid a version confusion for the future?

Co-authored-by: Taeho Kim <[email protected]>
@gnokoheat gnokoheat merged commit fb49440 into main Aug 8, 2021
@gnokoheat gnokoheat deleted the fix-fetch-notion-block branch August 8, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants