Code cleanup (#618)

* delete docs folder from master (#520)

* delete folder

* add back readme for docs

* Fix logger statement in User.add (#608)

The logger statement is using the parameter to output the id of the user, but that isnt set until line 67 and saved to a new variable. We want the logger statement to use that new user

* Cleans up imports and fixes some errors along the way

* pycodestyle fix for single char var name

Co-authored-by: Chris Shin <[email protected]>
Co-authored-by: Jac <[email protected]>
Co-authored-by: Reba Magier <[email protected]>

Author: 4 people

tableauserverclient/datetime_helpers.py

@@ -1,6 +1,8 @@
 import datetime
 
-# This code below is from the python documentation for tzinfo: https://docs.python.org/2.3/lib/datetime-tzinfo.html
+# This code below is from the python documentation for
+# tzinfo: https://docs.python.org/2.3/lib/datetime-tzinfo.html
+
 ZERO = datetime.timedelta(0)
 HOUR = datetime.timedelta(hours=1)
 

tableauserverclient/models/column_item.py

@@ -1,7 +1,6 @@
 import xml.etree.ElementTree as ET
 
-from .property_decorators import property_is_enum, property_not_empty
-from .exceptions import UnpopulatedPropertyError
+from .property_decorators import property_not_empty
 
 
 class ColumnItem(object):

tableauserverclient/models/connection_item.py

@@ -32,8 +32,10 @@ def connection_type(self):
         return self._connection_type
 
     def __repr__(self):
-        return "<ConnectionItem#{_id} embed={embed_password} type={_connection_type} username={username}>"\
-            .format(**self.__dict__)
+        return (
+            "<ConnectionItem#{_id} embed={embed_password} "
+            "type={_connection_type} username={username}>".format(**self.__dict__)
+        )
 
     @classmethod
     def from_response(cls, resp, ns):
@@ -76,11 +78,13 @@ def from_xml_element(cls, parsed_response, ns):
             connection_item.server_address = connection_xml.get('serverAddress', None)
             connection_item.server_port = connection_xml.get('serverPort', None)
 
-            connection_credentials = connection_xml.find('.//t:connectionCredentials', namespaces=ns)
+            connection_credentials = connection_xml.find(
+                './/t:connectionCredentials', namespaces=ns)
 
             if connection_credentials is not None:
 
-                connection_item.connection_credentials = ConnectionCredentials.from_xml_element(connection_credentials)
+                connection_item.connection_credentials = ConnectionCredentials.from_xml_element(
+                    connection_credentials)
 
         return all_connection_items
 

tableauserverclient/models/data_acceleration_report_item.py

@@ -21,10 +21,6 @@ def site(self):
         def sheet_uri(self):
             return self._sheet_uri
 
-        @property
-        def site(self):
-            return self._site
-
         @property
         def unaccelerated_session_count(self):
             return self._unaccelerated_session_count

tableauserverclient/models/database_item.py

@@ -1,7 +1,5 @@
 import xml.etree.ElementTree as ET
 
-from .permissions_item import Permission
-
 from .property_decorators import property_is_enum, property_not_empty, property_is_boolean
 from .exceptions import UnpopulatedPropertyError
 

tableauserverclient/models/flow_item.py

@@ -1,6 +1,6 @@
 import xml.etree.ElementTree as ET
 from .exceptions import UnpopulatedPropertyError
-from .property_decorators import property_not_nullable, property_is_boolean
+from .property_decorators import property_not_nullable
 from .tag_item import TagItem
 from ..datetime_helpers import parse_datetime
 import copy

tableauserverclient/models/interval_item.py

@@ -173,7 +173,7 @@ def interval(self, interval_value):
             try:
                 if not (1 <= int(interval_value) <= 31):
                     raise ValueError(error)
-            except ValueError as e:
+            except ValueError:
                 if interval_value != "LastDay":
                     raise ValueError(error)
 

tableauserverclient/models/job_item.py

@@ -1,7 +1,5 @@
 import xml.etree.ElementTree as ET
 from ..datetime_helpers import parse_datetime
-from .target import Target
-from ..datetime_helpers import parse_datetime
 
 
 class JobItem(object):

tableauserverclient/models/pagination_item.py

@@ -31,10 +31,10 @@ def from_response(cls, resp, ns):
         return pagination_item
 
     @classmethod
-    def from_single_page_list(cls, l):
+    def from_single_page_list(cls, single_page_list):
         item = cls()
         item._page_number = 1
-        item._page_size = len(l)
-        item._total_available = len(l)
+        item._page_size = len(single_page_list)
+        item._total_available = len(single_page_list)
 
         return item

tableauserverclient/models/personal_access_token_auth.py

@@ -8,7 +8,12 @@ def __init__(self, token_name, personal_access_token, site_id=''):
 
     @property
     def credentials(self):
-        return {'personalAccessTokenName': self.token_name, 'personalAccessTokenSecret': self.personal_access_token}
+        return {
+            'personalAccessTokenName': self.token_name,
+            'personalAccessTokenSecret': self.personal_access_token
+        }
 
     def __repr__(self):
-        return "<PersonalAccessToken name={} token={}>".format(self.token_name, self.personal_access_token)
+        return "<PersonalAccessToken name={} token={}>".format(
+            self.token_name, self.personal_access_token
+        )