Jac/schedules (#1266)

* Hotfix schedule_item.py for issue 1237 (#1239)
* Remove duplicate assignments to fields (#1244)

Co-authored-by: Tim Payne <[email protected]>
Co-authored-by: Austin <[email protected]>
Co-authored-by: Yasuhisa Yoshida <[email protected]>

Author: 4 people

tableauserverclient/models/datasource_item.py

@@ -326,17 +326,8 @@ def _parse_element(datasource_xml: ET.Element, ns: Dict) -> Tuple:
         updated_at = parse_datetime(datasource_xml.get("updatedAt", None))
         certification_note = datasource_xml.get("certificationNote", None)
         certified = str(datasource_xml.get("isCertified", None)).lower() == "true"
-        certification_note = datasource_xml.get("certificationNote", None)
-        certified = str(datasource_xml.get("isCertified", None)).lower() == "true"
-        content_url = datasource_xml.get("contentUrl", None)
-        created_at = parse_datetime(datasource_xml.get("createdAt", None))
-        datasource_type = datasource_xml.get("type", None)
-        description = datasource_xml.get("description", None)
         encrypt_extracts = datasource_xml.get("encryptExtracts", None)
         has_extracts = datasource_xml.get("hasExtracts", None)
-        id_ = datasource_xml.get("id", None)
-        name = datasource_xml.get("name", None)
-        updated_at = parse_datetime(datasource_xml.get("updatedAt", None))
         use_remote_query_agent = datasource_xml.get("useRemoteQueryAgent", None)
         webpage_url = datasource_xml.get("webpageUrl", None)
 

tableauserverclient/models/schedule_item.py

@@ -14,8 +14,6 @@
 )
 from .property_decorators import (
     property_is_enum,
-    property_not_nullable,
-    property_is_int,
 )
 
 Interval = Union[HourlyInterval, DailyInterval, WeeklyInterval, MonthlyInterval]
@@ -27,6 +25,7 @@ class Type:
         Flow = "Flow"
         Subscription = "Subscription"
         DataAcceleration = "DataAcceleration"
+        ActiveDirectorySync = "ActiveDirectorySync"
 
     class ExecutionOrder:
         Parallel = "Parallel"
@@ -74,11 +73,10 @@ def id(self) -> Optional[str]:
         return self._id
 
     @property
-    def name(self) -> str:
+    def name(self) -> Optional[str]:
         return self._name
 
     @name.setter
-    @property_not_nullable
     def name(self, value: str):
         self._name = value
 
@@ -91,7 +89,6 @@ def priority(self) -> int:
         return self._priority
 
     @priority.setter
-    @property_is_int(range=(1, 100))
     def priority(self, value: int):
         self._priority = value
 
@@ -101,7 +98,6 @@ def schedule_type(self) -> str:
 
     @schedule_type.setter
     @property_is_enum(Type)
-    @property_not_nullable
     def schedule_type(self, value: str):
         self._schedule_type = value