Skip to content

Commit 301c257

Browse files
Jordan WoodsJordan Woods
authored andcommitted
Repalce deprecated assertEquals with assertEqual
1 parent 5ce527a commit 301c257

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

tableauserverclient/models/favorites_item.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@
77

88
logger = logging.getLogger('tableau.models.favorites_item')
99

10+
1011
class Favorite:
1112
Workbook = 'workbook'
1213
Datasource = 'datasource'
1314
View = 'view'
1415
Project = 'project'
1516

17+
1618
def get_favorites(server_response, namespace):
1719
favorites = {
1820
'datasources': [],

test/test_favorites.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
ADD_FAVORITE_DATASOURCE_XML = 'favorites_add_datasource.xml'
1515
ADD_FAVORITE_PROJECT_XML = 'favorites_add_project.xml'
1616

17+
1718
class FavoritesTests(unittest.TestCase):
1819
def setUp(self):
1920
self.server = TSC.Server('http://test')
@@ -38,7 +39,7 @@ def test_get(self):
3839
self.assertEqual(len(self.user.favorites['views']), 1)
3940
self.assertEqual(len(self.user.favorites['projects']), 1)
4041
self.assertEqual(len(self.user.favorites['datasources']), 1)
41-
42+
4243
workbook = self.user.favorites['workbooks'][0]
4344
view = self.user.favorites['views'][0]
4445
datasource = self.user.favorites['datasources'][0]
@@ -80,7 +81,7 @@ def test_add_favorite_datasource(self):
8081
self.server.favorites.add_favorite_datasource(self.user, datasource)
8182

8283
def test_add_favorite_project(self):
83-
self.server.version='3.1'
84+
self.server.version = '3.1'
8485
baseurl = self.server.favorites.baseurl
8586
response_xml = read_xml_asset(ADD_FAVORITE_PROJECT_XML)
8687
project = TSC.ProjectItem('Tableau')
@@ -118,7 +119,7 @@ def test_delete_favorite_datasource(self):
118119
self.server.favorites.delete_favorite_datasource(self.user, datasource)
119120

120121
def test_delete_favorite_project(self):
121-
self.server.version='3.1'
122+
self.server.version = '3.1'
122123
baseurl = self.server.favorites.baseurl
123124
project = TSC.ProjectItem('Tableau')
124125
project._id = '1d0304cd-3796-429f-b815-7258370b9b74'

test/test_project.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,14 @@ def test_update_datasource_default_permission(self):
100100

101101
new_rules = self.server.projects.update_datasource_default_permissions(project, rules)
102102

103-
self.assertEquals('b4488bce-80f0-11ea-af1c-976d0c1dab39', new_rules[0].grantee.id)
103+
self.assertEqual('b4488bce-80f0-11ea-af1c-976d0c1dab39', new_rules[0].grantee.id)
104104

105105
updated_capabilities = new_rules[0].capabilities
106-
self.assertEquals(4, len(updated_capabilities))
107-
self.assertEquals('Deny', updated_capabilities['ExportXml'])
108-
self.assertEquals('Allow', updated_capabilities['Read'])
109-
self.assertEquals('Allow', updated_capabilities['Write'])
110-
self.assertEquals('Allow', updated_capabilities['Connect'])
106+
self.assertEqual(4, len(updated_capabilities))
107+
self.assertEqual('Deny', updated_capabilities['ExportXml'])
108+
self.assertEqual('Allow', updated_capabilities['Read'])
109+
self.assertEqual('Allow', updated_capabilities['Write'])
110+
self.assertEqual('Allow', updated_capabilities['Connect'])
111111

112112
def test_update_missing_id(self):
113113
single_project = TSC.ProjectItem('test')

0 commit comments

Comments
 (0)