Skip to content

feature: ecs,vpc,sg optionals #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Feb 4, 2022
Merged

feature: ecs,vpc,sg optionals #57

merged 34 commits into from
Feb 4, 2022

Conversation

wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Jan 31, 2022 •
edited
Loading

  • added uses-case for org-existing-cloudtrail-ecs-vpc-subnet
    • added ecs/vpc/subnet optionals on cloud-connector module and all examples

maintenance tasks

  • minnor renames that imply breaking changes on module
  • variable description clarifications
  • fixed README compliance feature docs link
  • updated diagrams and linked main readme with use-cases
  • removed region parameter from organizational snippet and fixed kitchen tests to avoid error
    • ⚠️ requires Sysig Secure onboarding changes

iru added 29 commits January 31, 2022 19:26
chore: ecs,vpc,sg optionals WIP
f09bfd2
chore: bump version
c1395a7
docs: add troubleshoot sns
f096045
docs: reorganize examples-internal
1efe4b7 
moved tf tests to use-cases to lower maintenance
test: WIP
491f17f
docs: use-case for org-existing-cloudtrail-ecs-vpc-subnet
fd0e933
chore: test terraform-docs 16
83250bb
chore: remove security-group for the moment
547e098
fix: not exposed secgroup
850f0a1
fix: org test with no region
0c59303
chore: rename example to cloudtrail_s3
0a78ff8
refact: sepparate sns/sns permissions
f51d5b8
chore: small changes
81104c3
chore: fix. test
c85ccd6
ci: test org withouth initial kitchen initial destroy
17bd6f2
chore: lint
19a28fc
chore: revert tfdocs 0.13 test
ec76c33
chore: tfdocs
218477e
ci: test org withouth initial kitchen initial destroy
2ddcd36
chore: tfdocs 0.16 test 2
179d61f
chore: fix compliance docs link
ef883de
ci: restore backend.tf on tests
49438bc
ci: test terraform-docs
0fba6ed
docs: min
3eb2805
docs: fix pre-commit and add notes for contributing -_-
bcfc988
docs: use-case clarification
745974a
docs: update diagrams
faf7cd6
docs: link readme with use-cases
c7b3ae1
chore: ¯\_(ツ)_/¯
4d3407d
@wideawakening wideawakening marked this pull request as ready for review February 4, 2022 10:06
@wideawakening wideawakening merged commit fd4e2fa into master Feb 4, 2022
@wideawakening wideawakening deleted the feature/ecs-vpc-sg-optionals branch February 4, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wideawakening