Skip to content

fix: ECS autoscale #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 30, 2023
Merged

fix: ECS autoscale #159

merged 11 commits into from
Jan 30, 2023

Conversation

wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Jan 30, 2023 •
edited
Loading

side-quest

  • expose as inputs autoscaling_confing

@wideawakening wideawakening changed the title fix: autoscale resource_id fix: ECS autoscale resource_id Jan 30, 2023
@wideawakening wideawakening changed the title fix: ECS autoscale resource_id fix: ECS autoscale Jan 30, 2023
@wideawakening wideawakening marked this pull request as ready for review January 30, 2023 16:36
@wideawakening wideawakening requested a review from a team as a code owner January 30, 2023 16:36
@wideawakening wideawakening merged commit 0ce09a9 into master Jan 30, 2023
@wideawakening wideawakening deleted the fix-autoscale branch January 30, 2023 18:25
@wideawakening wideawakening mentioned this pull request Jan 31, 2023
Merged
wideawakening pushed a commit that referenced this pull request Jan 31, 2023
fix: sanitized cluster name when using existing (#160)
301ecd9 
due to #159 , a bug was introduced for the usage of existing ecs_cluster
name.
renamed field to `sanitized_cluster_name` for clarity, and protected it
to fit both use-cases.

more in depth explanation

- input-variable format is `foo`
- while data format for the cluster_name is
`arn:aws:ecs:eu-west-3:425287181461:cluster/foo`. for the ECS autoscale,
we just need `foo`.

not sure about why data is so non-useful  ¯\_(ツ)_/¯
```
$ terraform state show module.aws_cloudvision_single_account.module.cloud_connector.data.aws_ecs_cluster.this

data "aws_ecs_cluster" "this" {
  arn                      = "arn:aws:ecs:eu-west-3:425287181461:cluster/foo"
  cluster_name    = "arn:aws:ecs:eu-west-3:425287181461:cluster/foo"
  id                         = "arn:aws:ecs:eu-west-3:425287181461:cluster/foo"
...
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wideawakening