feat: Enable Cloud Connector ECS autoscaling based on RAM #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+20
to
+21
| lifecycle { | ||
| ignore_changes = [desired_count] |
There was a problem hiding this comment.
what's the rationale on this? just curious :)
There was a problem hiding this comment.
We need to ignore the desired count because will be modified by the autoscaling and further terraform apply executions will modify this back to 1.
wideawakening
previously approved these changes
Jan 23, 2023
Comment on lines
+7
to
+10
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = "<4.51.0" | ||
| } |
There was a problem hiding this comment.
let's clarify that this version has been pinned due to an error with latest aws version, reported by @tembleking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
side-quest: aws version pinned due to hashicorp/terraform-provider-aws#29042