Skip to content

fix: Add ECRReader permission role to beta scanner ecr #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix: Add ECRReader permission role to beta scanner ecr #134

merged 2 commits into from
Oct 17, 2022

Conversation

miketnt
Copy link
Contributor

@miketnt miketnt commented Oct 14, 2022

Add back both resource and data "ecr_reader" when using beta_scanning

@miketnt
fix(registryscanner): Add ECRReader permission role
95cd951 
Add back both resource and data "ecr_reader" when using beta_scanning
@miketnt miketnt marked this pull request as ready for review October 14, 2022 15:48
@miketnt miketnt requested a review from a team as a code owner October 14, 2022 15:48
@hayk99 hayk99 self-requested a review October 17, 2022 13:34
hayk99
hayk99 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@hayk99 hayk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@miketnt miketnt merged commit d3f4866 into master Oct 17, 2022
@miketnt miketnt deleted the fix-registryscanner-single-account branch October 17, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayk99 hayk99 hayk99 approved these changes

+1 more reviewer

@regiluze regiluze regiluze approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketnt @regiluze @hayk99