Skip to content

Commit 0932aa6

Browse files
author
iru
authored
chore: resouce-group+tags usage awareness (#70)
* fix: create resource-group based on 'product' key tag * chore: remove rg outside examples * doc: raise awarenes on default 'product' tag for resource-group creation * doc: raise awareness on resource-groups * ci: avoid collision * doc: clarify rg is only on examples
1 parent 351c387 commit 0932aa6

File tree

28 files changed

+67
-65
lines changed

28 files changed

+67
-65
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,10 @@ $ terraform plan
106106
$ terraform apply
107107
```
108108

109-
Notice that:
110-
* This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
111-
* All created resources will be created within the tags `product:sysdig-secure-for-cloud`, within the resource-group `sysdig-secure-for-cloud`
109+
### Notice
110+
111+
* **Resource creation inventory** Find all the resources created by Sysdig examples in the resource-group `sysdig-secure-for-cloud` (AWS Resource Group & Tag Editor) <br/><br/>
112+
* **Deployment cost** This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
112113

113114
<br/><br/>
114115

examples-internal/organizational-k8s-threat-reuse_cloudtrail_s3/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@ This three-actor setup (S3-SNS-SQS) can be manually provisioned, or handled thro
2626
Client is responsible for provisioning the ARN of this SQS, which will be required as an input parameter.<br/>
2727
2828
29+
## Notice
30+
31+
* **Resource creation inventory** Find all the resources created by Sysdig examples in the resource-group `sysdig-secure-for-cloud` (AWS Resource Group & Tag Editor) <br/><br/>
32+
* **Deployment cost** This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
33+
34+
2935
## Usage
3036
3137
For quick testing, use this snippet on your terraform files.
@@ -75,10 +81,6 @@ $ terraform plan
7581
$ terraform apply
7682
```
7783

78-
Notice that:
79-
* This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
80-
* All created resources will be created within the tags `product:sysdig-secure-for-cloud`, within the resource-group `sysdig-secure-for-cloud`
81-
8284
<!-- BEGIN_TF_DOCS -->
8385
## Requirements
8486

examples-internal/organizational-k8s-threat-reuse_cloudtrail_s3/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ variable "name" {
3333

3434
variable "tags" {
3535
type = map(string)
36-
description = "sysdig secure-for-cloud tags"
36+
description = "sysdig secure-for-cloud tags. always include 'product' default tag for resource-group proper functioning"
3737
default = {
3838
"product" = "sysdig-secure-for-cloud"
3939
}

examples-internal/utils-eks/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ variable "region" {
2121

2222
variable "tags" {
2323
type = map(string)
24-
description = "sysdig secure-for-cloud tags"
24+
description = "sysdig secure-for-cloud tags. always include 'product' default tag for resource-group proper functioning"
2525
default = {
2626
"product" = "sysdig-secure-for-cloud"
2727
}

examples/organizational/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@ Minimum requirements:
3838
sysdig_secure_api_token=<SECURE_API_TOKEN>
3939
```
4040
41+
## Notice
42+
43+
* **Resource creation inventory** Find all the resources created by Sysdig examples in the resource-group `sysdig-secure-for-cloud` (AWS Resource Group & Tag Editor) <br/><br/>
44+
* **Deployment cost** This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
45+
4146
## Usage
4247
4348
For quick testing, use this snippet on your terraform files
@@ -87,10 +92,6 @@ $ terraform plan
8792
$ terraform apply
8893
```
8994

90-
Notice that:
91-
* This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
92-
* All created resources will be created within the tags `product:sysdig-secure-for-cloud`, within the resource-group `sysdig-secure-for-cloud`
93-
9495

9596
<!-- BEGIN_TF_DOCS -->
9697
## Requirements

examples/organizational/main.tf

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ module "resource_group" {
99
tags = var.tags
1010
}
1111

12+
module "resource_group_secure_for_cloud_member" {
13+
providers = {
14+
aws = aws.member
15+
}
16+
source = "../../modules/infrastructure/resource-group"
17+
name = var.name
18+
tags = var.tags
19+
}
1220

1321
#-------------------------------------
1422
# secure-for-cloud member account workload

examples/organizational/permissions.tf

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
module "resource_group_secure_for_cloud_member" {
2-
providers = {
3-
aws = aws.member
4-
}
5-
source = "../../modules/infrastructure/resource-group"
6-
name = var.name
7-
tags = var.tags
8-
}
9-
101
module "secure_for_cloud_role" {
112
source = "../../modules/infrastructure/permissions/org-role-ecs"
123
providers = {

examples/organizational/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ variable "name" {
142142

143143
variable "tags" {
144144
type = map(string)
145-
description = "sysdig secure-for-cloud tags"
145+
description = "sysdig secure-for-cloud tags. always include 'product' default tag for resource-group proper functioning"
146146
default = {
147147
"product" = "sysdig-secure-for-cloud"
148148
}

examples/single-account-k8s/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ Minimum requirements:
2121
sysdig_secure_api_token=<SECURE_API_TOKEN>
2222
```
2323

24+
## Notice
25+
26+
* **Resource creation inventory** Find all the resources created by Sysdig examples in the resource-group `sysdig-secure-for-cloud` (AWS Resource Group & Tag Editor) <br/><br/>
27+
* **Deployment cost** This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
28+
29+
2430
## Usage
2531

2632
For quick testing, use this snippet on your terraform files
@@ -63,10 +69,6 @@ $ terraform plan
6369
$ terraform apply
6470
```
6571

66-
Notice that:
67-
68-
* This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
69-
* All created resources will be created within the tags `product:sysdig-secure-for-cloud`, within the resource-group `sysdig-secure-for-cloud`
7072

7173
<!-- BEGIN_TF_DOCS -->
7274
## Requirements

examples/single-account-k8s/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ variable "name" {
3232

3333
variable "tags" {
3434
type = map(string)
35-
description = "sysdig secure-for-cloud tags"
35+
description = "sysdig secure-for-cloud tags. always include 'product' default tag for resource-group proper functioning"
3636
default = {
3737
"product" = "sysdig-secure-for-cloud"
3838
}

0 commit comments

Comments
 (0)