Skip to content

feat: Add retry strategy with backoff of 0.5s #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

tembleking
Copy link
Member

This PR implements retries in the Python SDK.

@tembleking tembleking self-assigned this Oct 27, 2020
@tembleking tembleking merged commit 8c918a1 into master Oct 27, 2020
@tembleking tembleking deleted the feat-retry-with-backoff branch October 27, 2020 13:12
@brackendawson
Copy link

brackendawson commented Nov 3, 2020

Hi, this appears to have broken IAM authentication:

Traceback (most recent call last):
  File "/home/jenkins/workspace/Containers-Registry/sync-sysdig-alerts/vaultfiles/scripts/sysdig/sync-alerts.py", line 29, in <module>
    source_client = create_sdcclient_for_instance(source_instance)
  File "/home/jenkins/workspace/Containers-Registry/sync-sysdig-alerts/vaultfiles/scripts/sysdig/sync-alerts.py", line 25, in create_sdcclient_for_instance
    ibm_headers = IbmAuthHelper.get_headers(url, api_key, guid)
  File "/usr/local/lib/python3.7/dist-packages/sdcclient/ibm_auth_helper.py", line 15, in get_headers
    iam_token = IbmAuthHelper.__get_iam_token(url, apikey)
  File "/usr/local/lib/python3.7/dist-packages/sdcclient/ibm_auth_helper.py", line 35, in __get_iam_token
    response = self.http.post(
NameError: name 'self' is not defined

I've raised #164

Thanks,
Bracken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants