Skip to content

Add support for non-conforming nullish values #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2023
Merged

Add support for non-conforming nullish values #3

merged 2 commits into from
May 23, 2023

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Some unified plugins generate such values.

@remcohaszing
Handle nullish unist position end values
f349e94 
Some unified plugins generate such values.
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 🤞 phase/open Post is being triaged manually labels May 23, 2023
ChristianMurphy
ChristianMurphy approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes.
LGTM, thanks @remcohaszing!

@wooorm wooorm changed the title Handle nullish unist position end values Add support for non-conforming nullish values May 23, 2023
@wooorm wooorm merged commit 29eea00 into main May 23, 2023
@wooorm wooorm deleted the invalid-unist-position-end branch May 23, 2023 15:50
@wooorm wooorm added the 💪 phase/solved Post is done label May 23, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label May 23, 2023
@wooorm
Copy link
Member

wooorm commented May 23, 2023

Do you want me to release this immediately? Are you planning further work?

@remcohaszing
Copy link
Member Author

IMO this may be released immediately. I'm not planning to make further changes to this repo atm.

@wooorm
Copy link
Member

wooorm commented May 25, 2023

Thanks, released in 1.0.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @wooorm @ChristianMurphy