apply rector and bump to PHP 8.2

Author: TomasVotruba

rector.php

@@ -4,41 +4,21 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
-use Rector\PHPUnit\Set\PHPUnitSetList;
-use Rector\Set\ValueObject\LevelSetList;
-use Rector\Set\ValueObject\SetList;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->sets([
-        PHPUnitSetList::PHPUNIT_100,
-        SetList::CODE_QUALITY,
-        SetList::DEAD_CODE,
-        LevelSetList::UP_TO_PHP_81,
-        SetList::CODING_STYLE,
-        SetList::TYPE_DECLARATION,
-        SetList::NAMING,
-        SetList::PRIVATIZATION,
-        SetList::EARLY_RETURN,
-        PHPUnitSetList::PHPUNIT_CODE_QUALITY,
-    ]);
-
-    $rectorConfig->paths([
+return RectorConfig::configure()
+    ->withPreparedSets(deadCode: true, codeQuality: true, codingStyle: true, typeDeclarations: true, naming: true, privatization: true)
+    ->withRootFiles()
+    ->withPhpSets()
+    ->withPaths([
         __DIR__ . '/src',
         __DIR__ . '/tests',
-    ]);
-
-    $rectorConfig->importNames();
-
-    $rectorConfig->skip([
+    ])
+    ->withSkip([
         '*/Source/*',
         '*/Fixture/*',
         // keep prefix
         StringClassNameToClassConstantRector::class => [
             // keep the container class string, to avoid prefixing
             __DIR__ . '/src/NodeFactory/ContainerConfiguratorReturnClosureFactory.php',
         ],
-
-        // preference
-        \Rector\CodingStyle\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector::class,
     ]);
-};

src/CaseConverter/AliasCaseConverter.php

@@ -21,7 +21,7 @@
 use Symplify\PhpConfigPrinter\ValueObject\VariableName;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class AliasCaseConverter implements CaseConverterInterface
+final readonly class AliasCaseConverter implements CaseConverterInterface
 {
     /**
      * @see https://regex101.com/r/BwXkfO/2/
@@ -36,9 +36,9 @@ final class AliasCaseConverter implements CaseConverterInterface
     private const NAMED_ALIAS_REGEX = '#\w+\s+\$\w+#';
 
     public function __construct(
-        private readonly CommonNodeFactory $commonNodeFactory,
-        private readonly ArgsNodeFactory $argsNodeFactory,
-        private readonly ServiceOptionNodeFactory $serviceOptionNodeFactory,
+        private CommonNodeFactory $commonNodeFactory,
+        private ArgsNodeFactory $argsNodeFactory,
+        private ServiceOptionNodeFactory $serviceOptionNodeFactory,
     ) {
     }
 

src/CaseConverter/ClassServiceCaseConverter.php

@@ -15,11 +15,11 @@
 use Symplify\PhpConfigPrinter\ValueObject\VariableName;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class ClassServiceCaseConverter implements CaseConverterInterface
+final readonly class ClassServiceCaseConverter implements CaseConverterInterface
 {
     public function __construct(
-        private readonly ArgsNodeFactory $argsNodeFactory,
-        private readonly ServiceOptionNodeFactory $serviceOptionNodeFactory
+        private ArgsNodeFactory $argsNodeFactory,
+        private ServiceOptionNodeFactory $serviceOptionNodeFactory
     ) {
     }
 

src/CaseConverter/ConfiguredServiceCaseConverter.php

@@ -15,11 +15,11 @@
 use Symplify\PhpConfigPrinter\ValueObject\VariableName;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class ConfiguredServiceCaseConverter implements CaseConverterInterface
+final readonly class ConfiguredServiceCaseConverter implements CaseConverterInterface
 {
     public function __construct(
-        private readonly ArgsNodeFactory $argsNodeFactory,
-        private readonly ServiceOptionNodeFactory $serviceOptionNodeFactory
+        private ArgsNodeFactory $argsNodeFactory,
+        private ServiceOptionNodeFactory $serviceOptionNodeFactory
     ) {
     }
 

src/CaseConverter/ImportCaseConverter.php

@@ -27,7 +27,7 @@
  *
  * imports: <---
  */
-final class ImportCaseConverter implements CaseConverterInterface
+final readonly class ImportCaseConverter implements CaseConverterInterface
 {
     /**
      * @see https://regex101.com/r/hOTdIE/1
@@ -36,8 +36,8 @@ final class ImportCaseConverter implements CaseConverterInterface
     private const INPUT_SUFFIX_REGEX = '#\.(yml|yaml|xml)$#';
 
     public function __construct(
-        private readonly YamlArgumentSorter $yamlArgumentSorter,
-        private readonly CommonNodeFactory $commonNodeFactory
+        private YamlArgumentSorter $yamlArgumentSorter,
+        private CommonNodeFactory $commonNodeFactory
     ) {
     }
 

src/CaseConverter/NameOnlyServiceCaseConverter.php

@@ -14,10 +14,10 @@
 use Symplify\PhpConfigPrinter\ValueObject\VariableName;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class NameOnlyServiceCaseConverter implements CaseConverterInterface
+final readonly class NameOnlyServiceCaseConverter implements CaseConverterInterface
 {
     public function __construct(
-        private readonly CommonNodeFactory $commonNodeFactory
+        private CommonNodeFactory $commonNodeFactory
     ) {
     }
 

src/CaseConverter/NestedCaseConverter/InstanceOfNestedCaseConverter.php

@@ -15,11 +15,11 @@
 use Symplify\PhpConfigPrinter\ValueObject\VariableName;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class InstanceOfNestedCaseConverter
+final readonly class InstanceOfNestedCaseConverter
 {
     public function __construct(
-        private readonly CommonNodeFactory $commonNodeFactory,
-        private readonly ServiceOptionNodeFactory $serviceOptionNodeFactory
+        private CommonNodeFactory $commonNodeFactory,
+        private ServiceOptionNodeFactory $serviceOptionNodeFactory
     ) {
     }
 

src/CaseConverter/ParameterCaseConverter.php

@@ -22,12 +22,12 @@
  *
  * parameters: <---
  */
-final class ParameterCaseConverter implements CaseConverterInterface
+final readonly class ParameterCaseConverter implements CaseConverterInterface
 {
     public function __construct(
-        private readonly ArgsNodeFactory $argsNodeFactory,
-        private readonly CurrentFilePathProvider $currentFilePathProvider,
-        private readonly CommonNodeFactory $commonNodeFactory
+        private ArgsNodeFactory $argsNodeFactory,
+        private CurrentFilePathProvider $currentFilePathProvider,
+        private CommonNodeFactory $commonNodeFactory
     ) {
     }
 

src/CaseConverter/ResourceCaseConverter.php

@@ -9,10 +9,10 @@
 use Symplify\PhpConfigPrinter\NodeFactory\Service\ServicesPhpNodeFactory;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class ResourceCaseConverter implements CaseConverterInterface
+final readonly class ResourceCaseConverter implements CaseConverterInterface
 {
     public function __construct(
-        private readonly ServicesPhpNodeFactory $servicesPhpNodeFactory
+        private ServicesPhpNodeFactory $servicesPhpNodeFactory
     ) {
     }
 

src/CaseConverter/ServicesDefaultsCaseConverter.php

@@ -14,10 +14,10 @@
 use Symplify\PhpConfigPrinter\ValueObject\VariableName;
 use Symplify\PhpConfigPrinter\ValueObject\YamlKey;
 
-final class ServicesDefaultsCaseConverter implements CaseConverterInterface
+final readonly class ServicesDefaultsCaseConverter implements CaseConverterInterface
 {
     public function __construct(
-        private readonly AutoBindNodeFactory $autoBindNodeFactory
+        private AutoBindNodeFactory $autoBindNodeFactory
     ) {
     }