Merge branch '5.4' into 6.3

nicolas-grekas · nicolas-grekas · commit 428f20bdadb1 · 2023-10-31T09:07:48.000+01:00
* 5.4:
  [Tests] Streamline
  [Validator] updated Romanian translation
diff --git a/Tests/Controller/ProfilerControllerTest.php b/Tests/Controller/ProfilerControllerTest.php
@@ -340,7 +340,7 @@ public function testPhpinfoActionWithProfilerDisabled()
         $twig = $this->createMock(Environment::class);
 
         $controller = new ProfilerController($urlGenerator, null, $twig, []);
-        $controller->phpinfoAction(Request::create('/_profiler/phpinfo'));
+        $controller->phpinfoAction();
     }
 
     public function testPhpinfoAction()
@@ -353,7 +353,7 @@ public function testPhpinfoAction()
         $this->assertStringContainsString('PHP License', $client->getResponse()->getContent());
     }
 
-    public static function provideCspVariants()
+    public static function provideCspVariants(): array
     {
         return [
             [true],
diff --git a/Tests/Csp/ContentSecurityPolicyHandlerTest.php b/Tests/Csp/ContentSecurityPolicyHandlerTest.php
@@ -46,7 +46,7 @@ public function testOnKernelResponse($nonce, $expectedNonce, Request $request, R
         }
     }
 
-    public static function provideRequestAndResponses()
+    public static function provideRequestAndResponses(): array
     {
         $nonce = bin2hex(random_bytes(16));
 
@@ -73,7 +73,7 @@ public static function provideRequestAndResponses()
         ];
     }
 
-    public static function provideRequestAndResponsesForOnKernelResponse()
+    public static function provideRequestAndResponsesForOnKernelResponse(): array
     {
         $nonce = bin2hex(random_bytes(16));
 
diff --git a/Tests/EventListener/WebDebugToolbarListenerTest.php b/Tests/EventListener/WebDebugToolbarListenerTest.php
@@ -148,7 +148,7 @@ public function testToolbarIsNotInjectedOnRedirection($statusCode)
         $this->assertEquals('<html><head></head><body></body></html>', $response->getContent());
     }
 
-    public static function provideRedirects()
+    public static function provideRedirects(): array
     {
         return [
             [301],
diff --git a/Tests/Resources/IconTest.php b/Tests/Resources/IconTest.php
@@ -32,7 +32,7 @@ public function testIconFileContents($iconFilePath)
         $this->assertMatchesRegularExpression('~<svg .* viewBox="0 0 \d+ \d+".+>.*</svg>~s', file_get_contents($iconFilePath), sprintf('The SVG file of the "%s" icon must include a "viewBox" attribute.', $iconFilePath));
     }
 
-    public static function provideIconFilePaths()
+    public static function provideIconFilePaths(): array
     {
         return array_map(fn ($filePath) => (array) $filePath, glob(__DIR__.'/../../Resources/views/Icon/*.svg'));
     }

Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ public function testPhpinfoActionWithProfilerDisabled()`
`340`	`340`	`$twig = $this->createMock(Environment::class);`
`341`	`341`
`342`	`342`	`$controller = new ProfilerController($urlGenerator, null, $twig, []);`
`343`		`- $controller->phpinfoAction(Request::create('/_profiler/phpinfo'));`
	`343`	`+ $controller->phpinfoAction();`
`344`	`344`	`}`
`345`	`345`
`346`	`346`	`public function testPhpinfoAction()`
`@@ -353,7 +353,7 @@ public function testPhpinfoAction()`
`353`	`353`	`$this->assertStringContainsString('PHP License', $client->getResponse()->getContent());`
`354`	`354`	`}`
`355`	`355`
`356`		`- public static function provideCspVariants()`
	`356`	`+ public static function provideCspVariants(): array`
`357`	`357`	`{`
`358`	`358`	`return [`
`359`	`359`	`[true],`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public function testOnKernelResponse($nonce, $expectedNonce, Request $request, R`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`49`		`- public static function provideRequestAndResponses()`
	`49`	`+ public static function provideRequestAndResponses(): array`
`50`	`50`	`{`
`51`	`51`	`$nonce = bin2hex(random_bytes(16));`
`52`	`52`
`@@ -73,7 +73,7 @@ public static function provideRequestAndResponses()`
`73`	`73`	`];`
`74`	`74`	`}`
`75`	`75`
`76`		`- public static function provideRequestAndResponsesForOnKernelResponse()`
	`76`	`+ public static function provideRequestAndResponsesForOnKernelResponse(): array`
`77`	`77`	`{`
`78`	`78`	`$nonce = bin2hex(random_bytes(16));`
`79`	`79`
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ public function testToolbarIsNotInjectedOnRedirection($statusCode)`
`148`	`148`	`$this->assertEquals('<html><head></head><body></body></html>', $response->getContent());`
`149`	`149`	`}`
`150`	`150`
`151`		`- public static function provideRedirects()`
	`151`	`+ public static function provideRedirects(): array`
`152`	`152`	`{`
`153`	`153`	`return [`
`154`	`154`	`[301],`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function testIconFileContents($iconFilePath)`
`32`	`32`	`$this->assertMatchesRegularExpression('~<svg .* viewBox="0 0 \d+ \d+".+>.*</svg>~s', file_get_contents($iconFilePath), sprintf('The SVG file of the "%s" icon must include a "viewBox" attribute.', $iconFilePath));`
`33`	`33`	`}`
`34`	`34`
`35`		`- public static function provideIconFilePaths()`
	`35`	`+ public static function provideIconFilePaths(): array`
`36`	`36`	`{`
`37`	`37`	`return array_map(fn ($filePath) => (array) $filePath, glob(__DIR__.'/../../Resources/views/Icon/*.svg'));`
`38`	`38`	`}`