Remove all "nullable-by-default-value" setters

nicolas-grekas · nicolas-grekas · commit bb7bc61433b3 · 2022-09-12T16:34:03.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add support for `FFI\CData` and `FFI\CType`
+ * Deprecate calling `VarDumper::setHandler()` without arguments
 
 5.4
 ---
diff --git a/VarDumper.php b/VarDumper.php
@@ -48,6 +48,9 @@ public static function dump(mixed $var)
 
     public static function setHandler(callable $callable = null): ?callable
     {
+        if (1 > \func_num_args()) {
+            trigger_deprecation('symfony/va-dumper', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
+        }
         $prevHandler = self::$handler;
 
         // Prevent replacing the handler with expected format as soon as the env var was set:

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,9 @@ public static function dump(mixed $var)`
`48`	`48`
`49`	`49`	`public static function setHandler(callable $callable = null): ?callable`
`50`	`50`	`{`
	`51`	`+ if (1 > \func_num_args()) {`
	`52`	`+ trigger_deprecation('symfony/va-dumper', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);`
	`53`	`+ }`
`51`	`54`	`$prevHandler = self::$handler;`
`52`	`55`
`53`	`56`	`// Prevent replacing the handler with expected format as soon as the env var was set:`