Use $initialData instead of 'data' in FormType to make tests easier to follow

Author: Lustmored

src/LiveComponent/tests/Fixtures/Component/FormComponentWithManyDifferentFieldsType.php

@@ -28,12 +28,18 @@ class FormComponentWithManyDifferentFieldsType extends AbstractController
     use ComponentWithFormTrait;
     use DefaultActionTrait;
 
+    public array $initialData = [];
+
     public function __construct(private FormFactoryInterface $formFactory)
     {
     }
 
     protected function instantiateForm(): FormInterface
     {
-        return $this->formFactory->createNamed('form', FormWithManyDifferentFieldsType::class);
+        return $this->formFactory->createNamed(
+            'form',
+            FormWithManyDifferentFieldsType::class,
+            $this->initialData
+        );
     }
 }

src/LiveComponent/tests/Fixtures/Form/FormWithManyDifferentFieldsType.php

@@ -55,20 +55,16 @@ public function buildForm(FormBuilderInterface $builder, array $options)
                 ],
                 'expanded' => true,
                 'multiple' => true,
-                'data' => [2],
             ])
             ->add('select_multiple', ChoiceType::class, [
                 'choices' => [
                     'foo' => 1,
                     'bar' => 2,
                 ],
                 'multiple' => true,
-                'data' => [2],
             ])
             ->add('checkbox', CheckboxType::class)
-            ->add('checkbox_checked', CheckboxType::class, [
-                'data' => true,
-            ])
+            ->add('checkbox_checked', CheckboxType::class)
             ->add('file', FileType::class)
             ->add('hidden', HiddenType::class)
         ;

src/LiveComponent/tests/Functional/Form/ComponentWithFormTest.php

@@ -157,7 +157,16 @@ public function testHandleCheckboxChanges(): void
         $factory = self::getContainer()->get('ux.twig_component.component_factory');
 
         /** @var FormComponentWithManyDifferentFieldsType $component */
-        $component = $factory->create('form_with_many_different_fields_type');
+        $component = $factory->create(
+            'form_with_many_different_fields_type',
+            [
+                'initialData' => [
+                    'choice_multiple' => [2],
+                    'select_multiple' => [2],
+                    'checkbox_checked' => true
+                ]
+            ]
+        );
 
         $dehydrated = $hydrator->dehydrate($component);
         $bareForm = [
@@ -195,7 +204,7 @@ public function testHandleCheckboxChanges(): void
                 self::assertEquals($fullBareData, $data['form']);
 
                 // check both multiple fields
-                $bareForm['choice_multiple'] = $fullBareData['choice_multiple'] = ['2', '1'];
+                $bareForm['choice_multiple'] = $fullBareData['choice_multiple'] = ['1', '2'];
 
                 $dehydrated['form'] = $bareForm;
             })

src/LiveComponent/tests/Unit/Form/ComponentWithFormTest.php

@@ -25,6 +25,11 @@ public function testFormValues(): void
     {
         $formFactory = self::getContainer()->get('form.factory');
         $component = new FormComponentWithManyDifferentFieldsType($formFactory);
+        $component->initialData = [
+            'choice_multiple' => [2],
+            'select_multiple' => [2],
+            'checkbox_checked' => true
+        ];
         $component->postMount([]);
 
         $this->assertSame(