feature #547 [WIP] All Package directory restructure (weaverryan)

This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[WIP] All Package directory restructure

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Tickets       | Fix #463
| License       | MIT

Hi!

To easy package maintenance and make it faster/easier/more consistent to add new packages, this PR restructures most packages to use the latest bundle directory structure best practice.

Most notably:

* `assets/` moved to the root
* `Resources/` removed entirely (and things inside of it, like `doc/` moved to root)
* `Tests` -> `tests/`

Want to help review? Please navigate the fork - https://github.com/weaverryan/ux/tree/package-restructure - and tell me if you notice anything missing/wrong/needs to be moved, etc. Let's do this once and get it right!

Recipes PR: symfony/recipes#1144

Cheers!

TODOs

- [x] fix CI
- [x] update CHANGELOGs
- [ ] check to see if Flex update `package.json` automatically for the `Resources/assets/` -> `assets/` move
- [ ] `symfony/ux-turbo-mercure` sub-tree split location changed - need to "ok" that with Fabien
- [X]  [Autocomplete] `routes.php` changed location - need to mention in CHANGELOG and update recipe
- [X] [Live] `live_component.xml` routing moved... and probably we should fully change from XML -> PHP

Commits
-------

561a4a3 [WIP] All Package directory restructure

Author: weaverryan

.github/workflows/test-turbo.yml

@@ -77,15 +77,15 @@ jobs:
                       ${{ runner.os }}-yarn-
 
             - name: Install JavaScript dependencies
-              working-directory: src/Turbo/Tests/app
+              working-directory: src/Turbo/tests/app
               run: yarn install
 
             - name: Build JavaScript
-              working-directory: src/Turbo/Tests/app
+              working-directory: src/Turbo/tests/app
               run: yarn build
 
             - name: Create DB
-              working-directory: src/Turbo/Tests/app
+              working-directory: src/Turbo/tests/app
               run: php public/index.php doctrine:schema:create
 
             - name: Run tests
@@ -139,15 +139,15 @@ jobs:
                       ${{ runner.os }}-yarn-
 
             - name: Install JavaScript dependencies
-              working-directory: src/Turbo/Tests/app
+              working-directory: src/Turbo/tests/app
               run: yarn install
 
             - name: Build JavaScript
-              working-directory: src/Turbo/Tests/app
+              working-directory: src/Turbo/tests/app
               run: yarn build
 
             - name: Create DB
-              working-directory: src/Turbo/Tests/app
+              working-directory: src/Turbo/tests/app
               run: php public/index.php doctrine:schema:create
 
             - name: Run tests

package.json

@@ -1,14 +1,13 @@
 {
     "private": true,
     "workspaces": [
-        "src/**/Resources/assets",
         "src/**/assets"
     ],
     "scripts": {
         "build": "yarn rollup -c",
         "test": "yarn workspaces run jest",
         "lint": "yarn workspaces run eslint src test",
-        "format": "prettier src/*/Resources/assets/src/*.ts src/*/Resources/assets/test/*.js {,src/*/}*.{json,md} --write",
+        "format": "prettier src/*/assets/src/*.ts src/*/assets/test/*.js {,src/*/}*.{json,md} --write",
         "check-lint": "yarn lint --no-fix",
         "check-format": "yarn format --no-write --check"
     },
@@ -61,7 +60,6 @@
         "overrides": [
             {
                 "files": [
-                    "src/*/Resources/assets/test/**/*.ts",
                     "src/*/assets/test/**/*.ts"
                 ],
                 "extends": [

rollup.config.js

@@ -38,7 +38,7 @@ const wildcardExternalsPlugin = (peerDependencies) => ({
     }
 });
 
-const files = glob.sync("src/**/assets/src/*controller.ts");
+const files = glob.sync("src/React/assets/src/*controller.ts");
 const packages = files.map((file) => {
     const absolutePath = path.join(__dirname, file);
     const packageData = require(pkgUp.sync({ cwd: absolutePath }));

src/Autocomplete/.symfony.bundle.yaml

@@ -1,3 +1,3 @@
 branches: ["2.x"]
 maintained_branches: ["2.x"]
-doc_dir: "src/Resources/doc"
+doc_dir: "doc"

src/Autocomplete/CHANGELOG.md

@@ -10,7 +10,7 @@ export default class extends Controller {
         noMoreResultsText: String,
         minCharacters: Number,
         tomSelectOptions: Object,
-    }
+    };
 
     readonly urlValue: string;
     readonly optionsAsHtmlValue: boolean;
@@ -53,7 +53,7 @@ export default class extends Controller {
     }
 
     #getCommonConfig(): Partial<TomSettings> {
-        const plugins: any = {}
+        const plugins: any = {};
 
         // multiple values excepted if this is NOT A select (i.e. input) or a multiple select
         const isMultiple = !this.selectElement || this.selectElement.multiple;
@@ -80,7 +80,7 @@ export default class extends Controller {
             onItemAdd: () => {
                 this.tomSelect.setTextboxValue('');
             },
-            onInitialize: function() {
+            onInitialize: function () {
                 const tomSelect = this as any;
                 tomSelect.wrapper.setAttribute('data-live-ignore', '');
             },
@@ -114,12 +114,12 @@ export default class extends Controller {
                 };
             },
             render: {
-                item: function(item: any) {
+                item: function (item: any) {
                     return `<div>${item.text}</div>`;
                 },
-                option: function(item: any) {
+                option: function (item: any) {
                     return `<div>${item.text}</div>`;
-                }
+                },
             },
         });
 
@@ -139,9 +139,12 @@ export default class extends Controller {
             load: function (query: string, callback: (results?: any) => void) {
                 const url = this.getUrl(query);
                 fetch(url)
-                    .then(response => response.json())
+                    .then((response) => response.json())
                     // important: next_url must be set before invoking callback()
-                    .then(json => { this.setNextUrl(query, json.next_page); callback(json.results) })
+                    .then((json) => {
+                        this.setNextUrl(query, json.next_page);
+                        callback(json.results);
+                    })
                     .catch(() => callback());
             },
             shouldLoad: function (query: string) {
@@ -150,16 +153,16 @@ export default class extends Controller {
                 return query.length >= minLength;
             },
             // avoid extra filtering after results are returned
-            score: function(search: string) {
-                return function(item: any) {
+            score: function (search: string) {
+                return function (item: any) {
                     return 1;
                 };
             },
             render: {
-                option: function(item: any) {
+                option: function (item: any) {
                     return `<div>${item.text}</div>`;
                 },
-                item: function(item: any) {
+                item: function (item: any) {
                     return `<div>${item.text}</div>`;
                 },
                 no_more_results: (): string => {
@@ -186,7 +189,7 @@ export default class extends Controller {
     /**
      * Returns the element, but only if it's a select element.
      */
-    get selectElement(): HTMLSelectElement|null {
+    get selectElement(): HTMLSelectElement | null {
         if (!(this.element instanceof HTMLSelectElement)) {
             return null;
         }
@@ -197,7 +200,7 @@ export default class extends Controller {
     /**
      * Getter to help typing.
      */
-    get formElement(): HTMLInputElement|HTMLSelectElement {
+    get formElement(): HTMLInputElement | HTMLSelectElement {
         if (!(this.element instanceof HTMLInputElement) && !(this.element instanceof HTMLSelectElement)) {
             throw new Error('Autocomplete Stimulus controller can only be used no an <input> or <select>.');
         }