getArrayValues should return empty array instead of null to mimic backend behavior

Author: Lustmored

src/LiveComponent/assets/src/get_array_value.ts

@@ -9,7 +9,7 @@ export function getArrayValue(
     element: HTMLElement,
     value: string|null,
     currentValue: any
-): Array<string>|null {
+): Array<string> {
     // Enforce returned value is an array
     if (!(currentValue instanceof Array)) {
         currentValue = [];
@@ -35,5 +35,5 @@ export function getArrayValue(
     }
 
     // When no values are selected for collection no data should be sent over the wire
-    return currentValue.length ? currentValue : null;
+    return currentValue;
 }

src/LiveComponent/assets/test/controller/model.test.ts

@@ -422,13 +422,13 @@ describe('LiveController data-model Tests', () => {
 
         await waitFor(() => expect(element).toHaveTextContent('Select: foo bar Option 2 is selected'));
 
-        mockRerender({ form: {select: null}}, checkboxTemplate);
+        mockRerender({ form: {select: []}}, checkboxTemplate);
 
         await userEvent.deselectOptions(selectElement, 'bar');
 
         await waitFor(() => expect(element).toHaveTextContent('Select: foo bar Option 2 is unselected'));
 
-        expect(controller.dataValue).toEqual({form: {select: null}});
+        expect(controller.dataValue).toEqual({form: {select: []}});
 
         // assert all calls were done the correct number of times
         fetchMock.done();

src/LiveComponent/assets/test/get_array_value.test.ts

@@ -21,9 +21,9 @@ describe('getArrayValue', () => {
         input.checked = false;
 
         expect(getArrayValue(input, 'foo', null))
-            .toEqual(null);
+            .toEqual([]);
         expect(getArrayValue(input, 'foo', ['foo']))
-            .toEqual(null);
+            .toEqual([]);
         expect(getArrayValue(input, 'foo', ['bar']))
             .toEqual(['bar']);
         expect(getArrayValue(input, 'foo', ['foo', 'bar']))
@@ -41,7 +41,7 @@ describe('getArrayValue', () => {
         select.add(barOption);
 
         expect(getArrayValue(select, '', null))
-            .toEqual(null);
+            .toEqual([]);
 
         fooOption.selected = true;
         expect(getArrayValue(select, '', null))