Skip to content

[HttpClient] Remove mentions to RequestFactory #18500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

[HttpClient] Remove mentions to RequestFactory #18500

merged 1 commit into from
Jul 6, 2023

Conversation

javiereguiluz
Copy link
Member

Fixes #18488.

I propose to just remove this brief mention to this interface, without adding a deprecation message.

@javiereguiluz javiereguiluz added this to the 6.2 milestone Jul 5, 2023
@javiereguiluz javiereguiluz mentioned this pull request Jul 5, 2023
Closed
@alamirault alamirault mentioned this pull request Jul 5, 2023
Merged
javiereguiluz added a commit that referenced this pull request Jul 6, 2023
@javiereguiluz
minor #18521 Fix comma space (alamirault)
be6407e 
This PR was merged into the 5.4 branch.

Discussion
----------

Fix comma space

It's minor, but while reviewing #18500 (6.2), I saw a missing space after comma

I checked all occurrences with `[a-zA-Z],[a-zA-Z]`, it's the only mistake on branch 5.4

Commits
-------

3114363 Fix comma space
@javiereguiluz javiereguiluz merged commit 3cb3f0f into symfony:6.2 Jul 6, 2023
@javiereguiluz javiereguiluz deleted the fix_18488 branch July 6, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @OskarStark @carsonbot