Skip to content

[minor] Use correct code block #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 16, 2021

We use html+php on all other places with short open syntax.

@OskarStark
Copy link
Contributor

You can extend the DOCtor rule if you like to spot these issues

@Nyholm
Copy link
Member Author

Nyholm commented Apr 16, 2021

It was just this one =)

I've looked at all other code block =)

Btw, we have html+twig and twig. What is the difference?

@wouterj
Copy link
Member

wouterj commented Apr 16, 2021

Btw, we have html+twig and twig. What is the difference?

Same as with php and html+php. {{ form_row(form) }} is twig, <div>{{ form_label(form) }}</div> is html+twig

@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 17, 2021
@javiereguiluz javiereguiluz changed the base branch from 5.x to 4.4 April 17, 2021 14:48
@javiereguiluz javiereguiluz force-pushed the minor-code-block-type branch from a9a3290 to 28d79d6 Compare April 17, 2021 14:48
@javiereguiluz
Copy link
Member

Thank you! Merged in 4.4 and up

@javiereguiluz javiereguiluz merged commit f5c2b2e into symfony:4.4 Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants