-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Labels
SecurityhasPRA Pull Request has already been submitted for this issue.A Pull Request has already been submitted for this issue.
Description
Security concern: If $token->nonce
is set to [ANY USER INPUT] and later we run file_put_contents($token->nonce, time())
are we allowing hackers to destroy any www-writable file in the system?
I did notice that $nonce
is run through base64_decode($nonce)
. Could this Regex be updated to only accept a Base64 string [a-zA-Z+/]+={0,2}
for the nonce?
Metadata
Metadata
Assignees
Labels
SecurityhasPRA Pull Request has already been submitted for this issue.A Pull Request has already been submitted for this issue.