[make:crud] default to final

Author: jrushlow

src/Maker/MakeCrud.php

@@ -27,6 +27,7 @@
 use Symfony\Bundle\MakerBundle\Maker\Common\CanGenerateTestsTrait;
 use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
 use Symfony\Bundle\MakerBundle\Str;
+use Symfony\Bundle\MakerBundle\Util\ClassSource\Model\ClassData;
 use Symfony\Bundle\MakerBundle\Util\UseStatementGenerator;
 use Symfony\Bundle\MakerBundle\Validator;
 use Symfony\Bundle\TwigBundle\TwigBundle;
@@ -131,6 +132,11 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             ];
         }
 
+        $controllerClassData = ClassData::create(
+            class: sprintf('App\Controller\%sController', $this->controllerClassName),
+            extendsClass: AbstractController::class,
+        );
+
         $controllerClassDetails = $generator->createClassNameDetails(
             $this->controllerClassName,
             'Controller\\',
@@ -174,6 +180,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             $controllerClassDetails->getFullName(),
             'crud/controller/Controller.tpl.php',
             array_merge([
+                'class_data' => $controllerClassData,
                 'use_statements' => $useStatements,
                 'entity_class_name' => $entityClassDetails->getShortName(),
                 'form_class_name' => $formClassDetails->getShortName(),
@@ -242,10 +249,9 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
         }
 
         if ($this->shouldGenerateTests()) {
-            $testClassDetails = $generator->createClassNameDetails(
-                sprintf('\\App\\Tests\\Controller\\%s', $entityClassDetails->getRelativeNameWithoutSuffix()),
-                'Controller\\',
-                'ControllerTest'
+            $testClassData = ClassData::create(
+                class: sprintf('App\Tests\Controller\%sControllerTest', $entityClassDetails->getRelativeNameWithoutSuffix()),
+                extendsClass: WebTestCase::class,
             );
 
             $useStatements = new UseStatementGenerator([
@@ -262,17 +268,16 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             }
 
             $generator->generateClass(
-                $testClassDetails->getFullName(),
+                $testClassData->fullClassName,
                 'crud/test/Test.EntityManager.tpl.php',
                 [
+                    'class_data' => $testClassData,
                     'use_statements' => $useStatements,
                     'entity_full_class_name' => $entityClassDetails->getFullName(),
                     'entity_class_name' => $entityClassDetails->getShortName(),
                     'entity_var_singular' => $entityVarSingular,
                     'route_path' => Str::asRoutePath($controllerClassDetails->getRelativeNameWithoutSuffix()),
                     'route_name' => $routeName,
-                    'class_name' => Str::getShortClassName($testClassDetails->getFullName()),
-                    'namespace' => Str::getNamespace($testClassDetails->getFullName()),
                     'form_fields' => $entityDoctrineDetails->getFormFields(),
                     'repository_class_name' => EntityManagerInterface::class,
                     'form_field_prefix' => strtolower(Str::asSnakeCase($entityTwigVarSingular)),

src/Resources/skeleton/crud/controller/Controller.tpl.php

@@ -5,7 +5,7 @@
 <?= $use_statements; ?>
 
 #[Route('<?= $route_path ?>')]
-class <?= $class_name ?> extends AbstractController
+<?= $class_data->getClassDeclaration() ?>
 {
 <?= $generator->generateRouteForControllerMethod('/', sprintf('%s_index', $route_name), ['GET']) ?>
 <?php if (isset($repository_full_class_name)): ?>

src/Resources/skeleton/crud/test/Test.EntityManager.tpl.php

@@ -5,7 +5,7 @@
 
 <?= $use_statements; ?>
 
-class <?= $class_name ?> extends WebTestCase<?= "\n" ?>
+<?= $class_data->getClassDeclaration() ?>
 {
     private KernelBrowser $client;
     private EntityManagerInterface $manager;

src/Util/ClassSource/Model/ClassData.php

@@ -23,6 +23,7 @@ final class ClassData
     private function __construct(
         public readonly string $className,
         public readonly string $namespace,
+        public readonly string $fullClassName,
         public readonly ?string $extends,
         public readonly bool $isEntity,
         private bool $isFinal = true,
@@ -34,8 +35,9 @@ public static function create(string $class, ?string $extendsClass = null, bool
         return new self(
             className: Str::getShortClassName($class),
             namespace: Str::getNamespace($class),
+            fullClassName: $class,
             extends: null === $extendsClass ? null : Str::getShortClassName($extendsClass),
-            isEntity: $isEntity
+            isEntity: $isEntity,
         );
     }
 

tests/Util/ClassSource/ClassDataTest.php

@@ -27,6 +27,7 @@ public function testStaticConstructor(): void
 
         self::assertSame('MakerBundle', $meta->className);
         self::assertSame('Symfony\Bundle\MakerBundle', $meta->namespace);
+        self::assertSame('Symfony\Bundle\MakerBundle\MakerBundle', $meta->fullClassName);
     }
 
     public function testGetClassDeclaration(): void

tests/fixtures/make-crud/expected/WithCustomRepository.php

@@ -12,7 +12,7 @@
 use Symfony\Component\Routing\Attribute\Route;
 
 #[Route('/sweet/food')]
-class SweetFoodController extends AbstractController
+final class SweetFoodController extends AbstractController
 {
     #[Route('/', name: 'app_sweet_food_index', methods: ['GET'])]
     public function index(SweetFoodRepository $sweetFoodRepository): Response