Skip to content

Commit 6712534

Browse files
committed
[libc++] [test] Run the clang-format and generated-output checks on the "service" queue
As these jobs only run in a couple seconds, and block starting of other jobs, they can run on the "service" queue which doesn't get blocked by other long-running jobs. Differential Revision: https://reviews.llvm.org/D101437
1 parent 5f51fb3 commit 6712534

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

libcxx/utils/ci/buildkite-pipeline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ steps:
2727
artifact_paths:
2828
- "**/clang-format.patch"
2929
agents:
30-
queue: "libcxx-builders"
30+
queue: "service"
3131
retry:
3232
automatic:
3333
- exit_status: -1 # Agent was lost
@@ -40,7 +40,7 @@ steps:
4040
artifact_paths:
4141
- "**/generated_output.patch"
4242
agents:
43-
queue: "libcxx-builders"
43+
queue: "service"
4444
retry:
4545
automatic:
4646
- exit_status: -1 # Agent was lost

libcxx/utils/ci/run-buildbot

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99

1010
set -ex
1111
set -o pipefail
12+
unset LANG
13+
unset LC_ALL
14+
unset LC_COLLATE
1215

1316
PROGNAME="$(basename "${0}")"
1417

@@ -146,6 +149,7 @@ check-generated-output)
146149
# Check if the diffs are empty, fail otherwise.
147150
! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false
148151
# Reject patches that introduce non-ASCII characters or hard tabs.
152+
# Depends on LC_COLLATE set at the top of this script.
149153
! grep -rn '[^ -~]' libcxx/include/ || false
150154
# Check that no dependency cycles have been introduced.
151155
python3 libcxx/utils/graph_header_deps.py >/dev/null

0 commit comments

Comments
 (0)