-
-
Notifications
You must be signed in to change notification settings - Fork 51
Update toolchain version, script, and README.md
#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
1c2d096
fb798a5
3601a34
e14ee9d
3254c81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
wasm-5.3-SNAPSHOT-2020-10-02-a | ||
wasm-5.3-SNAPSHOT-2020-10-16-a |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,13 +18,16 @@ fi | |
|
||
case $(uname -s) in | ||
Darwin) | ||
toolchain_download="$swift_tag-osx.tar.gz" | ||
toolchain_download="$swift_tag-macos-x86_64.tar.gz" | ||
echo '-macos' >> .swift-version | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need this line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still waiting for the new 5.3 toolchain to be tagged tonight that fixes this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's cleaned up now, ready for review. |
||
;; | ||
Linux) | ||
if [ $(grep RELEASE /etc/lsb-release) == "DISTRIB_RELEASE=18.04" ]; then | ||
toolchain_download="$swift_tag-ubuntu18.04.tar.gz" | ||
toolchain_download="$swift_tag-ubuntu18.04-x86_64.tar.gz" | ||
echo '-ubuntu18.04' >> .swift-version | ||
elif [ $(grep RELEASE /etc/lsb-release) == "DISTRIB_RELEASE=20.04" ]; then | ||
toolchain_download="$swift_tag-ubuntu20.04.tar.gz" | ||
toolchain_download="$swift_tag-ubuntu20.04-x86_64.tar.gz" | ||
echo '-ubuntu20.04' >> .swift-version | ||
else | ||
echo "Unknown Ubuntu version" | ||
exit 1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vendor name can be updated 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that swiftwasm/swift#1921 is not included in 5.3 branch 😢 But now, it's ok without SwiftWasm vendor name...