Skip to content

Calculate V1 resolved package identity correctly #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2022
Merged

Calculate V1 resolved package identity correctly #435

merged 3 commits into from
Oct 27, 2022

Conversation

adam-fowler
Copy link
Contributor

Previous code was just lowercasing the package name, when the identity should be extracted from the URL

@adam-fowler adam-fowler requested a review from 0xTim October 27, 2022 10:18
@adam-fowler adam-fowler mentioned this pull request Oct 27, 2022
Closed
stevapple
stevapple reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@stevapple stevapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s add a test case here to ensure we don’t break it accidentally?

@adam-fowler adam-fowler merged commit c426c06 into swiftlang:main Oct 27, 2022
@adam-fowler adam-fowler deleted the fix/package-v1-identity branch October 27, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevapple stevapple stevapple requested changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-fowler @0xTim @stevapple