Update DYLD_LIBRARY_PATH to fix debugging tests in nightly toolchains #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in SwiftPM removed the rpath that pointed to `usr/lib/swift/macosx/testing` (swiftlang/swift-package-manager#8295). Consequently when debugging tests in VS Code `libTesting.dylib` could not be found and the tests would not start. This is only happening in nightly toolchains that contain the SwiftPM change noted above. Fix this by adding the search path to the DYLD_LIBRARY_PATH.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
| } | ||
| return path.join(base, "usr/lib"); | ||
| return `${result}${path.join(this.toolchainPath, "lib/swift/macosx/testing")}`; |
There was a problem hiding this comment.
I think it's just missing usr/ prefix, now
Suggested change
| return `${result}${path.join(this.toolchainPath, "lib/swift/macosx/testing")}`; | |
| return `${result}${path.join(this.toolchainPath, "usr/lib/swift/macosx/testing")}`; |
There was a problem hiding this comment.
this.toolchainPath already has /usr prefixed in the path, the comment on it says "one folder up from the swift bin path": https://github.com/swiftlang/vscode-swift/pull/1521/files#diff-219ebe526be52811261023900cb320d9e51723308f63891304bfe53dcab033f1R107
The commit message has a bit of history there that predates my time, it may not be true anymore, however it would be a bigger change to update the toolchainPath everywhere.
There was a problem hiding this comment.
Ah, ok if it already has that prefix then great! 👍
rbenegal
approved these changes
Apr 24, 2025
stmontgomery
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in SwiftPM removed the rpath that pointed to
usr/lib/swift/macosx/testing(swiftlang/swift-package-manager#8295).
Consequently when debugging tests in VS Code
libTesting.dylibcould not be found and the tests would not start. This is only happening in nightly toolchains that contain the SwiftPM change noted above.Fix this by adding the search path to the DYLD_LIBRARY_PATH.