Add test debugging tests #1111
Add test debugging tests #1111
Conversation
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
force-pushed
the
debugging-tests-2
branch
19 times, most recently
from
81e83a3 to
1df0f5c
Compare
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
| @@ -39,7 +39,6 @@ module.exports = defineConfig({ | |||
| invert: isFastTestRun, | |||
| slow: 10000 | |||
| }, | |||
| installExtensions: ["vadimcn.vscode-lldb"], | |||
There was a problem hiding this comment.
This is redundant due to the extensionDependencies defined in package.json
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
6 similar comments
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
plemarquand
force-pushed
the
debugging-tests-2
branch
from
1df0f5c to
05376fc
Compare
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
| }); | ||
| }; | ||
|
|
||
| const changeMonitor = vscode.workspace.onDidChangeConfiguration(event => { |
There was a problem hiding this comment.
what is the change from the user perspective? This seems to do more than just add new tests, I guess mostly just enabling us to switch debuggers during a test run?
There was a problem hiding this comment.
This fixes a bug. Changing the debug adapter didn't require a restart of the extension. When you changed the debug adapter nothing re-registered the adapter/loggingDebugAdapter.
There was a problem hiding this comment.
It was uncovered by the tests since they did need to switch the debug adapter without restarting the extension
There was a problem hiding this comment.
Changing the debug adapter didn't require a restart of the extension
do you mean changing did require a restart?
There was a problem hiding this comment.
@award999 I mean it did require a restart, but there was no dialog that popped up prompting a restart.
cool I was going crazy, idk why GitHub was not showing these |
|
@award999 GitHub did that thing where if the diff is too big it doesn't show the file and you have to click Load Diff. Such an annoyance. |
test/integration-tests/testexplorer/TestExplorerIntegration.test.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| }; | ||
|
|
||
| const changeMonitor = vscode.workspace.onDidChangeConfiguration(event => { |
There was a problem hiding this comment.
Changing the debug adapter didn't require a restart of the extension
do you mean changing did require a restart?
test/integration-tests/testexplorer/TestExplorerIntegration.test.ts
Outdated
Show resolved
Hide resolved
Adds two new tests that test using the debug adapter in the toolchain to run a test, as well as a test that uses CodeLLDB. This required some new test utilities to set application settings at the start of a test and then set them back to their original value after each test. - Fixes up an issue where the LD_LIBRARY_PATH was not set for lldb on linux. - Fixes up an issue where when switching the useDebugAdapterInToolchain setting the loggingDebugAdapter wasn't reconfigured
plemarquand
force-pushed
the
debugging-tests-2
branch
from
7109bf7 to
2d23462
Compare
Adds new tests that test using the debug adapter in the toolchain to run a test, as well as a test that uses CodeLLDB.
This required some new test utilities to set application settings at the start of a test and then set them back to their original value after each test.