Skip to content

No longer notified to reload after xcode-select #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
award999 opened this issue Mar 31, 2025 · 3 comments
Open

No longer notified to reload after xcode-select #1472

award999 opened this issue Mar 31, 2025 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@award999
Copy link
Contributor

Describe the bug
We used to notify the user to reload the extension after detecting and xcode-select

To Reproduce
Steps to reproduce the behavior:

  1. Run the Swift: Select Toolchain... command and select a version of Xcode
  2. When prompted, reload the extension
  3. Outside VSCode, xcode-select -s a different Xcode
  4. Nothing happens in VSCode

Expected behavior
A clear and concise description of what you expected to happen.

Environment

  • OS: macOS
  • Swift version: 6.1
  • Visual Studio Code version: 1.98.2
  • vscode-swift version: main

Additional context
N/A
@award999 award999 added the bug Something isn't working label Mar 31, 2025
@plemarquand
Copy link
Contributor

I think this is intended because you explicitly set a toolchain path in your settings using the first command. If a toolchain is set in settings the prompt won't appear because the user has explicitly overridden the toolchain and the system Xcode has no effect. See: https://github.com/swiftlang/vscode-swift/blob/main/src/toolchain/SelectedXcodeWatcher.ts#L75

@award999 award999 added enhancement New feature or request and removed bug Something isn't working labels Mar 31, 2025
@award999
Copy link
Contributor Author

ah so that's a distinction I didn't know about. I'll swap this from a bug to future enhancement. I never really know if I have it explicitly set in setting or if it is working off the xcode-select value so we could always prompt "We noticed you changed the xcode-select'ed version of Xcode....want to update the setting?"

@award999
Copy link
Contributor Author

award999 commented Apr 2, 2025

Maybe even have a "system default" option in the toolchain selection

@award999 award999 moved this from Unscreened to Backlog in Swift Extension for Visual Studio Code Apr 2, 2025
@award999 award999 added the good first issue Good for newcomers label Apr 2, 2025
@award999 award999 moved this from Backlog to In Progress in Swift Extension for Visual Studio Code May 15, 2025
award999 added a commit to award999/vscode-swift that referenced this issue May 15, 2025
@award999
Notify user if the xcode-selected Xcode doesn't match setting
8d41c48 
If the Xcode selected via xcode-select changes and the user has a "swift.path"
setting configured, show warning notification suggesting they remove the
setting or "Select Toolchain"

Also trigger this warning on startup if the toolchain path is not under the
selected Xcode.app

Issue: swiftlang#1472
@award999 award999 mentioned this issue May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Swift Extension for Visual Studio Code
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plemarquand @award999